Roll src/third_party/dart 83fba7b..fe666ce (3 commits) (flutter#15619)

bkonyi · web-flow · commit 82a851cf21cf · 2020-01-14T12:06:56.000-08:00
fe666ce Report unused public static members of private classes by Sam Rawlins · 14 hours ago 43ceb5c Revert "De-dup js_util between ddc and dart2js" by Vijay Menon · 15 hours ago 04e2c97 NNBD preview: Fix the position of the navigation by Sam Rawlins · 17 hours ago 83fba7b [ VM ] Move vmservice_io code from runtime/bin to dart:_internal/vm/bin by Ben Konyi · 18 hours ago c0b1a0a Switch analyzer perf to using analyzer Packages. by Konstantin Shcheglov · 18 hours ago 5b391ba [tests] Break the monolithic async* tests into multiple files by Nicholas Shahan · 19 hours ago 980a200 [vm/vmservice] Make sure writing service info file is awaited by Alexander Markov · 19 hours ago 7997162 Fix getHover test on Windows. by Konstantin Shcheglov · 19 hours ago 301a3a2 Fix incorrect .packages files in DAS tests. by Konstantin Shcheglov · 19 hours ago c41812b Incremental work in the completion_metrics.dart file. by Jaime Wren · 19 hours ago 5169a52 Use @patch for List.of factory constructor by Stephen Adams · 20 hours ago 2a7789d De-dup js_util between ddc and dart2js by Vijay Menon · 20 hours ago aaaaa47 [dartjs] Remove unsound `contains` method from AbstractValueDomain. by Mayank Patke · 20 hours ago fd9d3f9 relevance test re-structure by pq · 20 hours ago 5d96b23 [dartdevc] Fix analysis error in runtime library by Nicholas Shahan · 20 hours ago 2c121e4 Migration: modify pass through edit plans to integrate up the tree stepwise. by Paul Berry · 21 hours ago 6669849 Initial commit with some work starting the metrics collection around code completion metrics gathering. by Jaime Wren · 21 hours ago c6d6eed Include type arguments when converting to a stateful widget (issue 40095) by Brian Wilkerson · 22 hours ago b9c5798 Support latest analyzer in analyzer_plugin by Simon Binder · 22 hours ago 16f07ea Revert "Use nullable context type for operand of null-check operator." by Konstantin Shcheglov · 23 hours ago c8f2683 Add a reason to the MakeNullable change and plumb it through to the AtomicEdit by Brian Wilkerson · 23 hours ago 5357052 [vm/compiler] Fix handling of function types in type tests for type parameters by Alexander Markov · 23 hours ago 8a1a4e7 Add flag to specify which null-safety semantics to use for codegen by Sigmund Cherem · 23 hours ago b3c6af3 [vm/compiler] Introduce base class for instance calls in IL by Alexander Markov · 24 hours ago 67f3cf3 Revert "[vm, gc] Sweep non-executable large pages concurrently." by Ryan Macnak · 24 hours ago 00a6b52 Test that invocation of a method on a nullable interface type prefers nullable extension. by Konstantin Shcheglov · 24 hours ago b5f4351 Move ABSTRACT_SUPER_MEMBER_REFERENCE tests. by Konstantin Shcheglov · 25 hours ago ca31f1d Refactor FunctionExpressionInvocationResolver to support Never. by Konstantin Shcheglov · 25 hours ago 4495c2b [vm, gc] Run weak processing in parallel for old-space GCs. by Ryan Macnak · 26 hours ago 2dd37b6 Add findPackagesFrom(). by Konstantin Shcheglov · 27 hours ago abe7c1a When NNBD, use nullable iterable type for null-aware spreads. by Konstantin Shcheglov · 27 hours ago 6f1bcee Extract ifNull resolution in BinaryExpressionResolver. by Konstantin Shcheglov · 27 hours ago 9c9c283 [vm, gc] Remove dead allocation stats code. by Ryan Macnak · 27 hours ago a4207fd [vm/aot] Avoid loading the code register (in bare-AOT) and zeroing IC data reg (in AOT) for closure calls by Martin Kustermann · 33 hours ago base 4cb8816 [gardening] Also ignore OSError in verify_http_timeline_test. by Teagan Strickland · 34 hours ago d1e11f0 Enable prefer_final_fields in three packages by Brian Wilkerson · 2 days ago 856a270 Use nullable context type for operand of null-check operator. by Konstantin Shcheglov · 2 days ago da6696b Use analyzer Packages. by Konstantin Shcheglov · 2 days ago 5b1065a Enable avoid_init_to_null in analysis_server by Brian Wilkerson · 2 days ago 99cdbee Use getDisplayString() for hover. by Konstantin Shcheglov · 2 days ago 04b5bd9 Extract null check in PostfixExpressionResolver. by Konstantin Shcheglov · 2 days ago ac8a2a6 Enable avoid_init_to_null in analyzer_plugin by Brian Wilkerson · 2 days ago f1c81da Add a fix for unnecessary_null_in_of_null_operators by Brian Wilkerson · 2 days ago 9254683 Remove packageMap and hasFlutterDependency from Workspace interface. by Konstantin Shcheglov · 2 days ago ecebc29 Do negation resolution in one method. by Konstantin Shcheglov · 2 days ago 489c0be Extract PostfixExpressionResolver. by Konstantin Shcheglov · 2 days ago 113f034 completion manager test harness by pq · 2 days ago 7ed7bff Fix some hints caused by previous CL and add some failing tests by Brian Wilkerson · 3 days ago
diff --git a/DEPS b/DEPS
@@ -34,7 +34,7 @@ vars = {
   # Dart is: https://github.com/dart-lang/sdk/blob/master/DEPS.
   # You can use //tools/dart/create_updated_flutter_deps.py to produce
   # updated revision list of existing dependencies.
-  'dart_revision': '28c335d5a201795f219d50ac608732eb937d7f27',
+  'dart_revision': 'fe666ce592cbf7d31184c0f1275a1658a443c1dd',
 
   # WARNING: DO NOT EDIT MANUALLY
   # The lines between blank lines above and below are generated by a script. See create_updated_flutter_deps.py
diff --git a/ci/licenses_golden/licenses_third_party b/ci/licenses_golden/licenses_third_party
diff --git a/lib/snapshot/libraries.json b/lib/snapshot/libraries.json
@@ -151,8 +151,8 @@
         "uri": "../../lib/ui/ui.dart"
       },
       "vmservice_io": {
-        "uri": "../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"
+        "uri": "../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"
       }
     }
   }
-}
+}
diff --git a/lib/snapshot/libraries.yaml b/lib/snapshot/libraries.yaml
@@ -151,4 +151,4 @@ flutter:
       uri: "../../../third_party/dart/sdk/lib/vmservice/vmservice.dart"
 
     vmservice_io:
-      uri: "../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"
+      uri: "../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"
diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn
@@ -2,7 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import("//third_party/dart/runtime/bin/vmservice/vmservice_sources.gni")
 import("$flutter_root/common/config.gni")
 import("$flutter_root/testing/testing.gni")
 
diff --git a/shell/platform/fuchsia/dart_runner/kernel/libraries.json b/shell/platform/fuchsia/dart_runner/kernel/libraries.json
@@ -157,8 +157,8 @@
         "uri": "../../../../../../flutter/shell/platform/fuchsia/dart_runner/embedder/builtin.dart"
       },
       "vmservice_io": {
-        "uri": "../../../../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"
+        "uri": "../../../../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"
       }
     }
   }
-}
+}
diff --git a/shell/platform/fuchsia/dart_runner/kernel/libraries.yaml b/shell/platform/fuchsia/dart_runner/kernel/libraries.yaml
@@ -157,4 +157,4 @@ dart_runner:
       uri: "../../../../../../third_party/dart/sdk/lib/vmservice/vmservice.dart"
 
     vmservice_io:
-      uri: "../../../../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"
+      uri: "../../../../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"
diff --git a/shell/platform/fuchsia/flutter/kernel/libraries.json b/shell/platform/fuchsia/flutter/kernel/libraries.json
@@ -160,8 +160,8 @@
         "uri": "../../../../../../flutter/lib/ui/ui.dart"
       },
       "vmservice_io": {
-        "uri": "../../../../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"
+        "uri": "../../../../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"
       }
     }
   }
-}
+}
diff --git a/shell/platform/fuchsia/flutter/kernel/libraries.yaml b/shell/platform/fuchsia/flutter/kernel/libraries.yaml
@@ -160,4 +160,4 @@ flutter_runner:
       uri: "../../../../../../third_party/dart/sdk/lib/vmservice/vmservice.dart"
 
     vmservice_io:
-      uri: "../../../../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"
+      uri: "../../../../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"
diff --git a/sky/packages/sky_engine/BUILD.gn b/sky/packages/sky_engine/BUILD.gn
@@ -222,12 +222,11 @@ dart_pkg("sky_engine") {
     deps += [ ":copy_sky_engine_authors" ]
   }
 
-  service_isolate_dir = "//third_party/dart/runtime/bin/vmservice"
+  service_isolate_dir = "//third_party/dart/sdk/lib/_internal/vm/bin/"
   sdk_ext_directory = "$root_gen_dir/sky/bindings"
   sdk_ext_files = [
     "$service_isolate_dir/vmservice_io.dart",
-    "$service_isolate_dir/loader.dart",
-    "$service_isolate_dir/server.dart",
+    "$service_isolate_dir/vmservice_server.dart",
   ]
 }
 
diff --git a/sky/packages/sky_engine/LICENSE b/sky/packages/sky_engine/LICENSE
diff --git a/tools/fuchsia/dart_kernel.gni b/tools/fuchsia/dart_kernel.gni
@@ -73,7 +73,7 @@ template("dart_kernel") {
       # build) causes the vm service isolate code to be tree-shaken from an app.
       # See the pragma on the entrypoint here:
       #
-      # https://github.com/dart-lang/sdk/blob/master/runtime/bin/vmservice/vmservice_io.dart#L240
+      # https://github.com/dart-lang/sdk/blob/master/sdk/lib/_internal/vm/bin/vmservice_io.dart#L240
       #
       # Also, this define excludes debugging and profiling code from Flutter.
       args += [ "-Ddart.vm.product=true" ]

Original file line number	Diff line number	Diff line change
`@@ -151,8 +151,8 @@`
`151`	`151`	`"uri": "../../lib/ui/ui.dart"`
`152`	`152`	`},`
`153`	`153`	`"vmservice_io": {`
`154`		`- "uri": "../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"`
	`154`	`+ "uri": "../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"`
`155`	`155`	`}`
`156`	`156`	`}`
`157`	`157`	`}`
`158`		`-}`
	`158`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -157,8 +157,8 @@`
`157`	`157`	`"uri": "../../../../../../flutter/shell/platform/fuchsia/dart_runner/embedder/builtin.dart"`
`158`	`158`	`},`
`159`	`159`	`"vmservice_io": {`
`160`		`- "uri": "../../../../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"`
	`160`	`+ "uri": "../../../../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"`
`161`	`161`	`}`
`162`	`162`	`}`
`163`	`163`	`}`
`164`		`-}`
	`164`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -160,8 +160,8 @@`
`160`	`160`	`"uri": "../../../../../../flutter/lib/ui/ui.dart"`
`161`	`161`	`},`
`162`	`162`	`"vmservice_io": {`
`163`		`- "uri": "../../../../../../third_party/dart/runtime/bin/vmservice/vmservice_io.dart"`
	`163`	`+ "uri": "../../../../../../third_party/dart/sdk/lib/_internal/vm/bin/vmservice_io.dart"`
`164`	`164`	`}`
`165`	`165`	`}`
`166`	`166`	`}`
`167`		`-}`
	`167`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -222,12 +222,11 @@ dart_pkg("sky_engine") {`
`222`	`222`	`deps += [ ":copy_sky_engine_authors" ]`
`223`	`223`	`}`
`224`	`224`
`225`		`- service_isolate_dir = "//third_party/dart/runtime/bin/vmservice"`
	`225`	`+ service_isolate_dir = "//third_party/dart/sdk/lib/_internal/vm/bin/"`
`226`	`226`	`sdk_ext_directory = "$root_gen_dir/sky/bindings"`
`227`	`227`	`sdk_ext_files = [`
`228`	`228`	`"$service_isolate_dir/vmservice_io.dart",`
`229`		`- "$service_isolate_dir/loader.dart",`
`230`		`- "$service_isolate_dir/server.dart",`
	`229`	`+ "$service_isolate_dir/vmservice_server.dart",`
`231`	`230`	`]`
`232`	`231`	`}`
`233`	`232`