bugfix: floats are 4 bytes long, not 8 bytes long

ericsalo · mcy · commit 456501ee7624 · 2022-07-25T12:12:43.000-04:00
diff --git a/testdata/groups.pb.golden b/testdata/groups.pb.golden
@@ -2,7 +2,7 @@
 1: !{
   1: 101
   2: 202i32
-  3: {"eieio"}
+  3: {12: 7.2232605e28i32}  # 0x6f696569i32
 }
 2:SGROUP
 3:EGROUP
diff --git a/testdata/maps-explicit-prefixes.pb.golden b/testdata/maps-explicit-prefixes.pb.golden
@@ -2918,7 +2918,7 @@
       1: 21
       2: 734803678
 12:LEN 39
-  1:LEN 5 `0d395b1400`
+  1:LEN 5 1: 1334073i32
   2:LEN 30
     1:LEN 13
       1: -200
diff --git a/testdata/maps.pb.golden b/testdata/maps.pb.golden
@@ -4172,7 +4172,7 @@
   }
 }
 12: {
-  1: {`0d395b1400`}
+  1: {1: 1334073i32}
   2: {
     1: {
       1: -200
diff --git a/testdata/no-groups.pb.golden b/testdata/no-groups.pb.golden
@@ -2,7 +2,7 @@
 1:SGROUP
   1: 101
   2: 202i32
-  3: {"eieio"}
+  3: {12: 7.2232605e28i32}  # 0x6f696569i32
 1:EGROUP
 2:SGROUP
 3:EGROUP
diff --git a/writer.go b/writer.go
@@ -309,7 +309,7 @@ func (w *writer) decodeField(src []byte) ([]byte, bool) {
 		}
 
 		// Assume this is a float by default.
-		if len(src) < 8 {
+		if len(src) < 4 {
 			return nil, false
 		}
 		bits := binary.LittleEndian.Uint32(src)

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,7 @@ func (w *writer) decodeField(src []byte) ([]byte, bool) {`
`309`	`309`	`}`
`310`	`310`
`311`	`311`	`// Assume this is a float by default.`
`312`		`- if len(src) < 8 {`
	`312`	`+ if len(src) < 4 {`
`313`	`313`	`return nil, false`
`314`	`314`	`}`
`315`	`315`	`bits := binary.LittleEndian.Uint32(src)`