Skip to content

Commit 50546da

Browse files
authored
[Fix]Remove modules from mmcv.runner and mmcv.utils (#1966)
* [WIP] mmcv-clean * [WIP]Remove modules from mmcv.runner and mmcv.utils * wip * fix import mmengine * remove ut * loadcheckpoint in mae
1 parent c932102 commit 50546da

File tree

77 files changed

+319
-302
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+319
-302
lines changed

.dev/benchmark_inference.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from argparse import ArgumentParser
88

99
import requests
10-
from mmcv import Config
10+
from mmengine import Config
1111

1212
from mmseg.apis import inference_model, init_model, show_result_pyplot
1313
from mmseg.utils import get_root_logger

.dev/gather_benchmark_evaluation_results.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import glob
44
import os.path as osp
55

6-
import mmcv
7-
from mmcv import Config
6+
from mmengine import Config
7+
from mmengine.fileio import dump, load
88

99

1010
def parse_args():
@@ -56,7 +56,7 @@ def parse_args():
5656
continue
5757

5858
log_json_path = list(sorted(json_list))[-1]
59-
metric = mmcv.load(log_json_path)
59+
metric = load(log_json_path)
6060
if config not in metric.get('config', {}):
6161
print(f'{config} not included in {log_json_path}')
6262
continue
@@ -84,7 +84,7 @@ def parse_args():
8484
new=new_metrics)
8585

8686
if metrics_out:
87-
mmcv.dump(result_dict, metrics_out, indent=4)
87+
dump(result_dict, metrics_out, indent=4)
8888
print('===================================')
8989
for config_name, metrics in result_dict.items():
9090
print(config_name, metrics)

.dev/gather_benchmark_train_results.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
import glob
33
import os.path as osp
44

5-
import mmcv
65
from gather_models import get_final_results
7-
from mmcv import Config
6+
from mmengine import Config
7+
from mmengine.fileio import dump
88

99

1010
def parse_args():
@@ -50,7 +50,7 @@ def parse_args():
5050
continue
5151

5252
# parse config
53-
cfg = mmcv.Config.fromfile(config)
53+
cfg = Config.fromfile(config)
5454
total_iters = cfg.runner.max_iters
5555
exp_metric = cfg.evaluation.metric
5656
if not isinstance(exp_metric, list):
@@ -93,7 +93,7 @@ def parse_args():
9393

9494
# 4 save or print results
9595
if metrics_out:
96-
mmcv.dump(result_dict, metrics_out, indent=4)
96+
dump(result_dict, metrics_out, indent=4)
9797
print('===================================')
9898
for config_name, metrics in result_dict.items():
9999
print(config_name, metrics)

.dev/gather_models.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@
77
import os.path as osp
88
import shutil
99

10-
import mmcv
1110
import torch
11+
from mmengine import Config
12+
from mmengine.fileio import dump
13+
from mmengine.utils import mkdir_or_exist, scandir
1214

1315
# build schedule look-up table to automatically find the final model
1416
RESULTS_LUT = ['mIoU', 'mAcc', 'aAcc']
@@ -100,10 +102,10 @@ def main():
100102
work_dir = args.work_dir
101103
collect_dir = args.collect_dir
102104
selected_config_name = args.config_name
103-
mmcv.mkdir_or_exist(collect_dir)
105+
mkdir_or_exist(collect_dir)
104106

105107
# find all models in the root directory to be gathered
106-
raw_configs = list(mmcv.scandir('./configs', '.py', recursive=True))
108+
raw_configs = list(scandir('./configs', '.py', recursive=True))
107109

108110
# filter configs that is not trained in the experiments dir
109111
used_configs = []
@@ -175,7 +177,7 @@ def main():
175177
print(f'dir {model_publish_dir} exists, no model found')
176178

177179
else:
178-
mmcv.mkdir_or_exist(model_publish_dir)
180+
mkdir_or_exist(model_publish_dir)
179181

180182
# convert model
181183
final_model_path = process_checkpoint(trained_model_path,
@@ -198,13 +200,13 @@ def main():
198200
if args.all:
199201
# copy config to guarantee reproducibility
200202
raw_config = osp.join('./configs', f'{config_name}.py')
201-
mmcv.Config.fromfile(raw_config).dump(
203+
Config.fromfile(raw_config).dump(
202204
osp.join(model_publish_dir, osp.basename(raw_config)))
203205

204206
publish_model_infos.append(model)
205207

206208
models = dict(models=publish_model_infos)
207-
mmcv.dump(models, osp.join(collect_dir, 'model_infos.json'), indent=4)
209+
dump(models, osp.join(collect_dir, 'model_infos.json'), indent=4)
208210

209211

210212
if __name__ == '__main__':

.dev/generate_benchmark_evaluation_script.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import argparse
33
import os.path as osp
44

5-
from mmcv import Config
5+
from mmengine import Config
66

77

88
def parse_args():

.dev/md2yml.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import sys
1414

1515
from lxml import etree
16-
from mmcv.fileio import dump
16+
from mmengine.fileio import dump
1717

1818
MMSEG_ROOT = osp.dirname(osp.dirname((osp.dirname(__file__))))
1919

demo/image_demo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Copyright (c) OpenMMLab. All rights reserved.
22
from argparse import ArgumentParser
33

4-
from mmengine.utils import revert_sync_batchnorm
4+
from mmengine.model import revert_sync_batchnorm
55

66
from mmseg.apis import inference_model, init_model, show_result_pyplot
77
from mmseg.utils import register_all_modules

demo/inference_demo.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"outputs": [],
2222
"source": [
2323
"import torch\n",
24-
"from mmengine import revert_sync_batchnorm\n",
24+
"from mmengine.model.utils import revert_sync_batchnorm\n",
2525
"from mmseg.apis import init_model, inference_model, show_result_pyplot\n",
2626
"from mmseg.utils import register_all_modules\n",
2727
"register_all_modules()"

demo/video_demo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from argparse import ArgumentParser
33

44
import cv2
5-
from mmengine.utils import revert_sync_batchnorm
5+
from mmengine.model.utils import revert_sync_batchnorm
66

77
from mmseg.apis import inference_model, init_model
88
from mmseg.apis.inference import show_result_pyplot

mmseg/apis/inference.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from mmengine import Config
1010
from mmengine.dataset import Compose
1111
from mmengine.runner import load_checkpoint
12+
from mmengine.utils import mkdir_or_exist
1213

1314
from mmseg.data import SegDataSample
1415
from mmseg.models import BaseSegmentor
@@ -179,7 +180,7 @@ def show_result_pyplot(model: BaseSegmentor,
179180
else:
180181
image = img
181182
if save_dir is not None:
182-
mmcv.mkdir_or_exist(save_dir)
183+
mkdir_or_exist(save_dir)
183184
# init visualizer
184185
visualizer = SegLocalVisualizer(
185186
vis_backends=[dict(type='LocalVisBackend')],

0 commit comments

Comments
 (0)