Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 7, 2025

Clean backport from 25, but it needed adaptions to Java 21.

In 21, Instant does not have a method until(). See second commit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8365790 needs maintainer approval

Issue

  • JDK-8365790: Shutdown hook for application image does not work on Windows (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2452/head:pull/2452
$ git checkout pull/2452

Update a local copy of the PR:
$ git checkout pull/2452
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2452

View PR using the GUI difftool:
$ git pr show -t 2452

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2452.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin changed the title Goetz backport 8365790 backport 8b686d9ee4669d31b306d7a3337a0b57e95c9a4c Nov 7, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 8b686d9ee4669d31b306d7a3337a0b57e95c9a4c 8365790: Shutdown hook for application image does not work on Windows Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 7, 2025
@GoeLin GoeLin force-pushed the goetz_backport_8365790 branch from 265668e to ba548cf Compare November 13, 2025 17:06
@GoeLin GoeLin force-pushed the goetz_backport_8365790 branch from ba548cf to 206bf9f Compare November 13, 2025 17:12
@GoeLin GoeLin marked this pull request as ready for review November 13, 2025 18:01
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants