Skip to content

Conversation

@shirmoran
Copy link

@shirmoran shirmoran commented Oct 29, 2025

- What I did
This PR adds a service to port 9637. As for now since it does not have a service, an endpointslice is not created and it is not included in the communication matrix. Adding a service should solve this issue.

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

@shirmoran: This pull request references Jira Issue OCPBUGS-50492, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is To Do instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
This PR adds a service to port 9637

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shirmoran
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen
Copy link
Member

/retest-required

@isabella-janssen
Copy link
Member

/payload-job ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@isabella-janssen: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@isabella-janssen
Copy link
Member

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2 periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@isabella-janssen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a3d7e9d0-b4d7-11f0-9dd3-fe6a8d08a4fa-0

@shirmoran shirmoran force-pushed the add-kube-rbac-proxy-service branch from b545186 to fe63fd5 Compare November 4, 2025 14:31
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2025
@shirmoran shirmoran force-pushed the add-kube-rbac-proxy-service branch from fe63fd5 to ddb9d8a Compare November 4, 2025 14:33
This PR adds a service to port 9637. As for now since it does not have a
service, an endpointslice is not created and it is not included in the
communication matrix. Adding a service should solve this issue.
@shirmoran shirmoran force-pushed the add-kube-rbac-proxy-service branch from ddb9d8a to 3ccd953 Compare November 4, 2025 14:38
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2025
@shirmoran shirmoran requested a review from yuqi-zhang November 4, 2025 14:38
@yuqi-zhang
Copy link
Contributor

/test verify

Also cc @rphillips since you initially had some concerns around doing this for purely documentation generation purposes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@shirmoran: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 3ccd953 link false /test bootstrap-unit
ci/prow/okd-scos-e2e-aws-ovn 3ccd953 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor

lgtm... It seems like that ship has sailed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants