-
Notifications
You must be signed in to change notification settings - Fork 457
OCPBUGS-50492: Add kube_rbac_proxy service #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@shirmoran: This pull request references Jira Issue OCPBUGS-50492, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shirmoran The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/payload-job ? |
|
@isabella-janssen: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2 periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive |
|
@isabella-janssen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a3d7e9d0-b4d7-11f0-9dd3-fe6a8d08a4fa-0 |
b545186 to
fe63fd5
Compare
fe63fd5 to
ddb9d8a
Compare
This PR adds a service to port 9637. As for now since it does not have a service, an endpointslice is not created and it is not included in the communication matrix. Adding a service should solve this issue.
ddb9d8a to
3ccd953
Compare
|
/test verify Also cc @rphillips since you initially had some concerns around doing this for purely documentation generation purposes |
|
@shirmoran: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
lgtm... It seems like that ship has sailed. |
- What I did
This PR adds a service to port 9637. As for now since it does not have a service, an endpointslice is not created and it is not included in the communication matrix. Adding a service should solve this issue.
- How to verify it
- Description for the changelog