Skip to content

OCPBUGS-65509: [release-4.20]: e2e gcp ocl PR backport #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: release-4.20
Choose a base branch
from
Open

OCPBUGS-65509: [release-4.20]: e2e gcp ocl PR backport #5407

wants to merge 8 commits into from
+1,371 −446

Conversation

@cheesesashimi
Copy link
Member

@cheesesashimi cheesesashimi commented Nov 11, 2025

- What I did

This is a manual backport of #5268

- How to verify it

- Description for the changelog

@cheesesashimi
detect if image exists or access is denied
377bd21 
This also adds e2e tests for edge-cases that may have been missed as
well as a test-case that exposes the clusters' internal image registry
(if it exists) and validates the error handling functions against it.

The exposure functions were repackaged from the devex helpers for easy
reuse across both contexts.
@cheesesashimi
check whether the image exists before trying to reuse it for MachineC…
faff386 
…onfigPools
@cheesesashimi
e2e test should check for init container status instead of overall po…
d68415f 
…d status
@cheesesashimi
move kernel type test into rollout test
a8836df
@cheesesashimi
install skopeo from source, when missing
bf110c4
@cheesesashimi
speed up e2e-ocl by deleting build pods
8087d19 
This also modifies the MachineConfigPool status updates to use the
constants we've added for that purpose instead of non-authoritative
strings.
@cheesesashimi
adds additional checks to annotation test
71b2a93
@cheesesashimi
consider UID when determining MOSB existence
1d87d4d 
The Assert() helper only considers the MOSB name and not its UID. This
causes a problem where the MOSB is replaced, but the assertion times out
waiting for the replacement since it does not know that it was actually
replaced.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@umohnani8
Copy link
Contributor

umohnani8 commented Nov 12, 2025

/test e2e-gcp-op-ocl

@umohnani8
Copy link
Contributor

umohnani8 commented Nov 12, 2025

/jira cherry-pick OCPBUGS-60157

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

@umohnani8: Jira Issue OCPBUGS-60157 has been cloned as Jira Issue OCPBUGS-65509. Will retitle bug to link to clone.
/retitle OCPBUGS-65509: [release-4.20]: e2e gcp ocl PR backport

In response to this:

/jira cherry-pick OCPBUGS-60157

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20]: e2e gcp ocl PR backport OCPBUGS-65509: [release-4.20]: e2e gcp ocl PR backport Nov 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

@cheesesashimi: This pull request references Jira Issue OCPBUGS-65509, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-60157 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

This is a manual backport of #5268

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umohnani8
Copy link
Contributor

umohnani8 commented Nov 12, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

@umohnani8: This pull request references Jira Issue OCPBUGS-65509, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umohnani8
Copy link
Contributor

umohnani8 commented Nov 12, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

@umohnani8: This pull request references Jira Issue OCPBUGS-65509, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-60157 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-60157 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr November 12, 2025 05:17
@umohnani8
Copy link
Contributor

umohnani8 commented Nov 12, 2025

/label backport-risk-assessed
/lgtm

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Nov 12, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cheesesashimi,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 1d87d4d link false /test okd-scos-e2e-aws-ovn
ci/prow/bootstrap-unit 1d87d4d link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isabella-janssen isabella-janssen Awaiting requested review from isabella-janssen

@pablintino pablintino Awaiting requested review from pablintino

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@rbbratta rbbratta

@eurijon eurijon

@zhaozhanqi zhaozhanqi

@lyman9966 lyman9966

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@imatza-rh imatza-rh

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.