Management of out of bounds deposits #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatemeh-i
merged commit 80a4c24
into
refactor-currency-services-focused-on-symbols
1 check passed
fatemeh-i
added a commit
that referenced
this pull request
Jan 25, 2025
* refactor currency services m1 ( apply deposit/withdraw methods for different types of currency) * refactor currency services m2 (create/ update currency service base on requirements) * refactor currency services m3 * - * Encapsulating various operations related to currency as much as possible * Add cryptoCurrency services (CryptoCurrencies have imps in addition of other currency informations) * start refactoring cryptoCurrency data models * start refactoring assign address algth * develop/change tests to cover new data models * . * sync * change strategy in fetching currencies * Try to modify the fk relations of the tables based on the new currency model. * try to pass diferent tests * change otc services base on new currency model * change primary field in currency model :((((((((( * change primary field in currency model :((((((((( * start developing crypto currency * - * - * complete crypto currency services (remove currency table from bc-gateway) * connect currency <-> cryptocurrency) * Complete connections: currency <-> cryptocurrency and Develop managing document services for external data of assets * Update security config * Comment 2 tests * set default value for some filds of impl * create system wallet for new currencies * Create wallet for system when creating new currency * Create wallet for system when creating new currency * - * change in assign address logic * change in test of assigning address * change life time in assigning address * change life time in assigning address * change life time in assigning address * change life time in assigning address * change in revoking address's scedule time * Have some temproray logic to hande gap between dev and otc branch * have some log to debug wallet sync process * have log to debug * have log to debug * Fetch all impls in single request and postprocess response base on each symbol * - * - * wallet's stat * fix conflict * remove omni-wallet-url temporary * add applicator to withdraw review * change in withdraws schema * add withdrawMin to currency Obj * add withdrawMin to currency Obj * Fix bug in updating currency * Fix bug in updating currency * - * - * Handle error in fetching balance of assets * Handle error in fetching balance of assets * Set log to debug * Set log to debug * Set log to debug * Set log to debug * change docker gateway ip address * change omni-wallet baseurl * change omni-wallet baseurl * Develop manual withdraw * Develop manual withdraw * Save sourceWalletId in manual withdraw * Fix bug in fetching withdraws * Fix bug in fetching withdraws * Add ascendingByTime field in Geting withdraw * Check amount validation in reserve a swap * Change securityConfig in getting chains * Change in fetching chins service * Develop custom message translation in error handling * Change security config in manual deposit * Change security config in manual deposit * Add extra-host to wallet service configuration * Add extra-host to otc services configuration * Disable security config for actuator endpoints * Calculate buy and sell price for each currency (#465) * Refactor history services (#473) * Remove pulling dev branch in otc workflow (#462) * Remove pulling dev branch in otc workflow * Remove pulling dev branch in otc workflow * Upgrade error-hanlder.version * Replace user_transctions with transactions for external use (#463) * Remove details from fiActions in wallet and accountant * Use enum for withdraw status * Use enum for more hardcoded variables * Use enum for transfer category * Modify database * Add try catch in wallet BackupService * FinancialActionJobKafka TBC * Adding rest services * Add admin tx for DEPOSIT_MANUALLY * Remove balance_before * Change fi_actions transfer ref to use uuid * Fix test failure * Fix type mismatch error * Make one test function suspended * Fix quote asset not included in estimated value * Edit schema Transaction refactor completed * Replace docker-compose with docker compose in workflows * Start to handle different type of gateways for currencies * Implement requred services for all type of gateways * Complete create new gateway service * Complete gateway services * Fix bug of currency creation * Fix bug of currency creation * Fix bug of currency creation * Refactor withdraw services (#464) * Start refactoring withdraw * Remove applied_fee Refactor withdraw service * Delete deprecated services * Add fee service * Fix amount mismatch * Fix user transaction service * Change getUserTransactions http method * - * Fix dependency bug * Fix schema.sql for old DB version * Set scale for Division Calculations * Set withdraw/deposit allowed field in a currency object using detail of it's gateways * Set withdraw/deposit allowed field in a currency object using detail of it's gateways * Clean up deposit withdraw services (#466) * Simplified deposit services * Clean up withdraw services * Fix quote asset not considered in total assets * Add docker compose instead of docker-compose in actions scripts * try to merge * add availableGatewayType to currency object * docker-compose -> docker compose (#471) * docker-compose -> docker compose * rm prefrences config from otc profile * Rm isCryptoCurrency field from currency class * Rm isCryptoCurrency field from currency class * Try to debug wrong value in availableGatewayType * Try to debug wrong value in availableGatewayType * Try to debug wrong value in availableGatewayType * Solve bug in having wrong value for availableGatewayType * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Replace main with MAIN in wallet proxy * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Set default value for advanced transfer * Transfer ref is not nullable field * Set default value for wallet type in advanced transfer * Set default value for wallet type in advanced transfer * Add swap category to user transactions history * Support get transactions history by admin * Fix change in balance calculation for swap category * sync * Add last update date and applicator to withdraw model * Add last update date and applicator to withdraw model * Handle off-chain withdraw request * Handle off-chain withdraw request * Handle off-chain withdraw request * Handle off-chain withdraw request * Handle off-chain withdraw request * Set default message in error handling process * refactor deposit's endpoints * Fetch seaps history for user and admin * Develop services to get history for transfer-based actions for trusted users and admins * Fix ithdrw search query * Fix withdrow search query * Fix withdrow search query * Fix withdrow search query * Fix withdrow search query * Fix deposit search param * Change swap history services * Fix query of swap history * Fix query of swap history * Fix query of swap history * Fix query of swap history * Fix query of swap history * Fix query of swap history * Fix query of swap history * Change in swap hitory detail * - * - * - * - * Alter table -> - * - * Fix a calculation issue in swap history * Consider attachment field for withdraw/deposit actions --------- Co-authored-by: Peyman <[email protected]> Co-authored-by: Peyman <[email protected]> * Manage of out of bounds deposits (#475) * management invalid deposits * Fix typo in naming a requestParam * Fix typo in naming a requestParam * Change rules in deposit validation * Change logic of handling invalid deposits * Change logic of handling invalid deposits * Change logic of handling invalid deposits * Change logic of handling invalid deposits * Change logic of handling invalid deposits * Change logic of handling invalid withdraws * Change in transfer response to return tx.id * Manage admin's bank data to assign off-chain gateways (#474) * Search by status in deposit history * Search by status in deposit history * sync * Fix merge conflicts * Reformating code * Change in naming payment currency * Record IPG deposits * Withdraw from otc to opex (#480) * New TransferMethod Added. * Update InitializeService * Rename BankData to Terminal. * change in schema.sql and method names * Update schema.sql * Refactor bankData to terminal concept * Rename dest_networks in withdraw requests * Change the schema to prevent creation of expired tables * Change the schema to prevent creation of expired tables * Change the schema to prevent creation of expired tables * Change the order of recording deposits and actual deposits * Change default value for status in deposit service * - * - * - * Add webhook controller * Update security config in opex * Add new workflow for test env * Change name of test workflow * Merge with otc branch * Set profile for extract token class * reset profile on auth class and change auth data in exchange profile * reset profile on auth class and change auth data in exchange profile * Set expire time for assigned addresses * Set expire time for assigned addresses * Comment initialized cammand in wallet module * reset security filter for can_withdraw service * reset security filter for can_withdraw service * Remove currencyInfo service from ipg module * reset security filter for /v2/transfer service * Finish scanner webhook service * Fix merger conflict * Fix import --------- Co-authored-by: fatemeh imanipour <[email protected]> Co-authored-by: Fatemeh imani <[email protected]> Co-authored-by: Amir Rajabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.