Use .raw assets as HDD_1 #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlausuch
force-pushed
the
raw_format_hdd
branch
from
af19221 to
cd50f6e
Compare
jlausuch
commented
Mar 27, 2023
| ASSET_256=ALP-Bedrock.x86_64-0.1-Default-encrypted-Build2.2.raw.sha256 \ | ||
| BUILD=2.2 \ | ||
| CHECKSUM_ASSET_1=$(cut -b-64 /var/lib/openqa/factory/other/ALP-Bedrock.x86_64-0.1-Default-encrypted-Build2.2.raw.sha256 | grep -E '[0-9a-f]{5,40}' | head -n1) \ | ||
| CHECKSUM_HDD_1=$(cut -b-64 /var/lib/openqa/factory/other/ALP-Bedrock.x86_64-0.1-Default-encrypted-Build2.2.raw.sha256 | grep -E '[0-9a-f]{5,40}' | head -n1) \ |
Contributor
Author
There was a problem hiding this comment.
This is the important change to review, the other files are just build number changes.
jlausuch
commented
Mar 27, 2023
| DISTRI=alp \ | ||
| FLAVOR=Default-encrypted \ | ||
| FULLURL=1 \ | ||
| HDD_1=ALP-Bedrock.x86_64-0.1-Default-encrypted-Build2.2.raw \ |
Contributor
Author
There was a problem hiding this comment.
This will fix this error: https://openqa.opensuse.org/tests/3193166
where HDD_1 was missing.
jlausuch
commented
Mar 27, 2023
| elif [[ $destiso =~ \.iso$ ]]; then | ||
| echo \" ''' + openqa_call_start_ex1(checksum, 'ISO') + '''\" | ||
| elif [[ $destiso =~ \.(hdd|qcow2|raw\.xz|raw\.gz|vhdx\.xz|vmdk\.xz)$ ]]; then | ||
| elif [[ $destiso =~ \.(hdd|qcow2|raw|raw\.xz|raw\.gz|vhdx\.xz|vmdk\.xz)$ ]]; then |
Contributor
Author
There was a problem hiding this comment.
This is the main feature change.
ALP produces a non-compressed RAW images for the encrypted flavor. Without this change, it's set as ASSET_1 instead of HDD_1: ASSET_1=ALP-Micro.x86_64-0.1-Default-encrypted-Build2.2.raw and the test fails: https://openqa.opensuse.org/tests/3193166
jlausuch
force-pushed
the
raw_format_hdd
branch
from
cd50f6e to
75f820f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALP produces a non-compressed RAW images for the encrypted flavor. Without this change, it's set as ASSET_1 instead of
HDD_1: ASSET_1=ALP-Micro.x86_64-0.1-Default-encrypted-Build2.2.rawand the test fails:https://openqa.opensuse.org/tests/3193166
Follow up from #209