Merge pull request #477 from mloviska/no_auto_investigation

Allow users to turn off investigation runs

Author: mergify[bot]

openqa-investigate

@@ -379,6 +379,7 @@ investigate() {
     group="$(echo "$job_data" | runjq -r '.job.parent_group + " / " + .job.group')" || return $?
     [[ "$group" = " / " ]] && [[ "$exclude_no_group" = "true" ]] && echo "Job w/o job group, \$exclude_no_group is set, skipping investigation" && return 0
     [[ "$group" =~ $exclude_group_regex ]] && echo "Job group '$group' matches \$exclude_group_regex '$exclude_group_regex', skipping investigation" && return 0
+    user_unset="$(echo "$job_data" | runjq -r '.job.settings.NO_INVESTIGATION')" && [[ ! "$user_unset" =~ "null" ]] && echo "NO_INVESTIGATION=1 detected, skipping" && return 0
 
     # Optionally we can find "first failed", could extend openQA investigation
     # method instead for we are just working based on supplied job which can

test/02-investigate.t

@@ -3,7 +3,7 @@
 source test/init
 bpan:source bashplus +err +fs +sym
 
-plan tests 98
+plan tests 100
 
 host=localhost
 url=https://localhost
@@ -90,6 +90,9 @@ client-get-job() {
         10035)
             echo '{"job": { "test": "vim", "result": "failed", "parent_group": "foo", "group": "bar", "settings": {"OPENQA_INVESTIGATE_ORIGIN": "10035"} } }'
             ;;
+        10042)
+            echo '{"job": { "test": "vim", "result": "failed", "group": "42", "settings": {"NO_INVESTIGATION": "1"} } }'
+            ;;
         404)
             echo '404 Not Found'
             ;;
@@ -225,6 +228,9 @@ get-dependencies-ajax() {
         10035)
             echo '{"cluster":{},"edges":[], "nodes":[{"id":10035,"state":"cancelled","result":"none"}]}'
             ;;
+        10042)
+            echo '{"cluster":{}, "edges":[], "nodes":[{"id":10042,"state":"done","result":"failed"}]}'
+            ;;
         *)
             echo '{"debug": "get-dependencies-ajax '"$tid"'"}'
             ;;
@@ -306,6 +312,10 @@ try force=true investigate 10031
 is "$rc" 0 'success when job is skipped (because of exclude_no_group and job w/o group)'
 has "$got" 'Job w/o job group, $exclude_no_group is set, skipping investigation'
 
+try investigate 10042
+is "$rc" 0 'NO_INVESTIGATION=1, a failed job with this variable should be skipped'
+has "$got" 'NO_INVESTIGATION=1 detected, skipping'
+
 test-post-investigate() {
     # job is one of the other investigation types, e.g. :investigate:last_good_tests
     try investigate 3001