Skip to content

Conversation

@ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented Sep 23, 2025

BATS tests are now producing both JUnit XML (for openQA processing) and TAP logs for human consumption. We have other upstream tests that use only JUnit XML that would benefit from this post fail hook: docker_testsuite & podman_e2e.

Related ticket: https://progress.opensuse.org/issues/186786

TODO

  • Update unit tests.
  • Update openqa-label-known-issues-and-investigate-hook to check testsuite names instead of BATS_PACKAGE.

In another PR: restart jobs and don't rely on RETRY.

Verification runs:

$ openqa-bats-review -n https://openqa.opensuse.org/tests/5338518#
INFO: Processing clone chain: 5338518 -> 5337019 -> 5337015 -> 5337007 -> 5337004 -> 5336991 -> 5336982 -> 5336974 -> 5336966 -> 5336959 -> 5336953 -> 5336947 -> 5336943 -> 5336928 -> 5336922 -> 5336915 -> 5336904 -> 5336900 -> 5336892 -> 5336890 -> 5336884 -> 5336840 -> 5336836 -> 5336077
INFO: Job 5337019 has no logs, skipping
...
INFO: Only one jobs with logs in chain. Exiting
openqa-bats-review -n https://openqa.suse.de/tests/19239056
INFO: Processing clone chain: 19239056 -> 19238546
INFO: No common failures across clone chain. Tagging as PASSED.

@ricardobranco777 ricardobranco777 marked this pull request as draft September 23, 2025 19:53
Copy link
Contributor

@d3flex d3flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me why openqa-bats-review has to be in this repo and not in osado?

@ricardobranco777
Copy link
Contributor Author

Can you remind me why openqa-bats-review has to be in this repo and not in osado?

To be run as a post hook script, but now we have this issue: https://suse.slack.com/archives/C02CANHLANP/p1758633673618689

@ricardobranco777 ricardobranco777 force-pushed the junit branch 2 times, most recently from 2136a2c to 98646ef Compare September 25, 2025 11:39
@ricardobranco777 ricardobranco777 force-pushed the junit branch 3 times, most recently from bbeba2d to e87cb2b Compare October 7, 2025 18:50
@ricardobranco777 ricardobranco777 marked this pull request as ready for review October 7, 2025 18:53
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OBS checks don't work due to the fork's repo name differing. Merging manually.

@okurz okurz merged commit 5fe2d11 into os-autoinst:master Oct 8, 2025
5 of 6 checks passed
@perlpunk
Copy link
Contributor

perlpunk commented Oct 9, 2025

It seems this is now failing in OBS:
https://build.opensuse.org/package/live_build_log/devel:openQA/os-autoinst-scripts/15.6/x86_64

[   27s] E           AttributeError: 'str' object has no attribute 'removeprefix'
[   27s] 
[   27s] openqa-bats-review:202: AttributeError

We should revert unless you have a quick fix for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants