Skip to content

Commit 3323835

Browse files
committed
Remove unnecessary rollup for angularjs example
1 parent 4400b86 commit 3323835

File tree

3 files changed

+17
-15
lines changed

3 files changed

+17
-15
lines changed

atmosphere-packages/angular-typescript-compiler/index.js

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -255,15 +255,17 @@ export class AngularTsCompiler {
255255
inputFile.addJavaScript(toBeAdded);
256256
}
257257
}
258-
const inputFile = inputFiles.find(file => {
259-
const filePath = file.getPathInPackage();
260-
return filePath.startsWith(prefix) &&
261-
filePath.indexOf('imports') === -1;
262-
});
263-
inputFile.addJavaScript({
264-
path: 'fakeLoader.js',
265-
data: fakeLoaderCode
266-
});
258+
if(fakeLoaderCode){
259+
const inputFile = inputFiles.find(file => {
260+
const filePath = file.getPathInPackage();
261+
return filePath.startsWith(prefix) &&
262+
filePath.indexOf('imports') === -1;
263+
});
264+
inputFile.addJavaScript({
265+
path: 'fakeLoader.js',
266+
data: fakeLoaderCode
267+
});
268+
}
267269
console.timeEnd(`[${prefix}]: TypeScript Files Compilation`);
268270
if (this.isRollup && !mainCodePath.includes('node_modules')) {
269271
console.time(`[${prefix}]: Rollup`);

examples/angularjs/.meteor/versions

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
2-
angular-compilers@0.2.9_4
3-
angular-html-compiler@0.2.9
4-
angular-scss-compiler@0.2.9_1
5-
angular-typescript-compiler@0.2.9_7
2+
angular-compilers@0.3.0
3+
angular-html-compiler@0.3.0
4+
angular-scss-compiler@0.3.0
5+
angular-typescript-compiler@0.3.0
66
77
88

examples/angularjs/run_tests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ exit_code=$?; if [ ${exit_code} -gt 0 ]; then exit ${exit_code}; fi
1010
echo "[MeteorCLI - angularjs] Testing Dev"
1111
npm run test:ci
1212
exit_code=$?; if [ ${exit_code} -gt 0 ]; then exit ${exit_code}; fi
13-
echo "[MeteorCLI - angularjs] Testing Production w/ Rollup"
14-
ROLLUP=1 meteor build ./.meteor/build-rollup
13+
echo "[MeteorCLI - angularjs] Testing Production"
14+
meteor build ./.meteor/build
1515
exit_code=$?; if [ ${exit_code} -gt 0 ]; then exit ${exit_code}; fi

0 commit comments

Comments
 (0)