Skip to content

Conversation

@gtamasi
Copy link
Collaborator

@gtamasi gtamasi commented Aug 22, 2024

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

List of Breaking Changes

progress with target

progress with add fk's

normalization logic for 1-1 relationships

progress

make sure both foreignkey and foreignkeys are not used at the same time

add foreignkey to omit

add tests for composite foreign keys in belongs to

kinda works?

belongsTo with tests

add sourcekey to helper

add and comment tests to has one

support for composite get¨

create indexes properly without reference

change test names

create composite key constraint

rename to foreignKeyConstraints

chore: add more tests and cleanup to branch (#5)

* add composite foreign key constraints with sync

* change composite fkey constraint name generation logic to be similar to other sequelize keys

* change composite fkey constraint name generation logic to be similar to other sequelize keys

* add more test cases

* add more tests for composite key constraints creation

* clean up a bit

* change variable name to avoid collision in options that doesnt appear in model definition .-.

* add extra teest for custom fk name

* more tests and cleanup

* more cleanup

remove commented tests
first test with hasOne fixed*

cleanup

remove one more = null definition

use targetKeyField as getter
@gtamasi gtamasi changed the title Gtamasi/composite fkey include feat: composite fkey include Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants