-
Notifications
You must be signed in to change notification settings - Fork 82
Open
Description
Right now the supported connection types of the client are hard coded:
substrate-connect/packages/connect/src/connector/smoldot-light.ts
Lines 41 to 42 in b3f5f3e
forbidTcp: true, // In order to avoid confusing inconsistencies between browsers and NodeJS, TCP connections are always disabled. | |
forbidNonLocalWs: true, // Prevents browsers from emitting warnings if smoldot tried to establish non-secure WebSocket connections |
Whilst they could be good defaults, to avoid issues stated in the comments, it would be great if the users of the library can
override them.
As a suggestion, all the connection type options that smoldot provides should be configurable:
forbidTcp: false,
forbidWs: false,
forbidNonLocalWs: false,
forbidWss: false,
The options can be added to the existing configuration interface:
substrate-connect/packages/connect/src/connector/smoldot-light.ts
Lines 118 to 121 in b3f5f3e
/** | |
* Configuration that can be passed to {createScClient}. | |
*/ | |
export interface Config { |
Douglasacost
Metadata
Metadata
Assignees
Labels
No labels