Skip to content

Commit 9df0797

Browse files
committed
Removes switching on read / write permissions for FB login
SDK 5+ no longer differentiates between read / write permissions as of facebook/facebook-ios-sdk@6c4ac12
1 parent 6bed45a commit 9df0797

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

ParseFacebookUtils/ParseFacebookUtils/Internal/AuthenticationProvider/iOS/PFFacebookMobileAuthenticationProvider.m

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,8 @@ - (instancetype)initWithApplication:(UIApplication *)application
4343
- (BFTask<NSDictionary<NSString *, NSString *>*> *)authenticateAsyncWithReadPermissions:(nullable NSArray<NSString *> *)readPermissions
4444
publishPermissions:(nullable NSArray<NSString *> *)publishPermissions
4545
fromViewComtroller:(UIViewController *)viewController {
46-
if (readPermissions && publishPermissions) {
47-
NSString *description = @"Read permissions are not permitted to be requested with publish permissions.";
48-
NSError *error = [NSError errorWithDomain:PFParseErrorDomain
49-
code:kPFErrorFacebookInvalidSession
50-
userInfo:@{ NSLocalizedDescriptionKey: description }];
51-
return [BFTask taskWithError:error];
52-
}
46+
47+
NSArray *permissions = [readPermissions arrayByAddingObjectsFromArray:publishPermissions];
5348

5449
BFTaskCompletionSource *taskCompletionSource = [BFTaskCompletionSource taskCompletionSource];
5550
FBSDKLoginManagerLoginResultBlock resultHandler = ^(FBSDKLoginManagerLoginResult *result, NSError *error) {
@@ -61,12 +56,9 @@ - (instancetype)initWithApplication:(UIApplication *)application
6156
taskCompletionSource.result = [PFFacebookPrivateUtilities userAuthenticationDataFromAccessToken:result.token];
6257
}
6358
};
64-
65-
if (publishPermissions) {
66-
[self.loginManager logInWithPermissions:publishPermissions fromViewController:viewController handler:resultHandler];
67-
} else {
68-
[self.loginManager logInWithPermissions:readPermissions fromViewController:viewController handler:resultHandler];
69-
}
59+
60+
[self.loginManager logInWithPermissions:permissions fromViewController:viewController handler:resultHandler];
61+
7062
return taskCompletionSource.task;
7163
}
7264

0 commit comments

Comments
 (0)