WL#13318 Cleanup cmake SSL library code in 5.6 and 5.7

This patch is for 5.6

Cmake changes to support:

WL#12903 BACKPORT OF WL#12361 - SUPPORT TLS 1.3 TO MYSQL 5.6 & 5.7
WL#13289 Remove yaSSL support from 5.6/5.7 codebase

In several CMakeLitst.txt files: remove obsolete cmake code for copying
OpenSSL .dll files on Windows.

In cmake/ssl.cmake:
- Add code to do version check for minor and fix version of ssl.
- SSL libraries version 1.1 on windows have changed names,
  so extend the list of names to search for in FIND_LIBRARY(...)
- Remove obsolete cmake code which tried to use openssl .dlls on windows.
- Translate WITH_SSL=system on Mac and Windows to known paths (same as 8.0)
  This is to simplify the work for developers: no need to download tarballs
    from pushbuild.
  Note that pushbuild will continue to use WITH_SSL=<path/to/custom/openssl>

In libmysql/CMakeLists.txt separate the LIBS macro into LIBS_TO_MERGE
and LIBS_TO_LINK, otherwise the code in MERGE_CONVENIENCE_LIBRARIES
may fail in mysterious ways. This is a backport from 8.0

Same patch as for 5.7 plus:
- disable -Wclass-memaccess warnings for modern C++ compilers.
- explicitly set -std=gnu++03 in order to be able to build with modern
  C++ compilers

Changes from the 5.7 patch *not* included
- 5.6 has no protobuf code
- ndbcluster does not build in 5.6 so cmake changes not backported

The current patch keeps "bundled" i.e. YaSSL as default.
This will be removed by WL#13289.

Change-Id: Id546350978fe579b77b144dfda2f4635c0600852

Author: Tor Didriksen

CMakeLists.txt

@@ -1,4 +1,4 @@
-# Copyright (c) 2006, 2018, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2006, 2019, Oracle and/or its affiliates. All rights reserved.
 # 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -40,6 +40,19 @@ IF(CMAKE_VERSION VERSION_EQUAL "3.0.0" OR
  CMAKE_POLICY(SET CMP0042 OLD)
 ENDIF()
 
+# In CMake 3.12 and above, the
+#
+# * ``check_include_file`` macro in the ``CheckIncludeFile`` module, the
+# * ``check_include_file_cxx`` macro in the
+#   ``CheckIncludeFileCXX`` module, and the
+# * ``check_include_files`` macro in the ``CheckIncludeFiles`` module
+#
+# now prefer to link the check executable to the libraries listed in the
+# ``CMAKE_REQUIRED_LIBRARIES`` variable.
+IF(POLICY CMP0075)
+  CMAKE_POLICY(SET CMP0075 OLD)
+ENDIF()
+
 MESSAGE(STATUS "Running cmake version ${CMAKE_VERSION}")
 
 # Will set GIT_EXECUTABLE and GIT_FOUND
@@ -113,6 +126,16 @@ ELSE()
       ${MYSQL_PROJECT_NAME_DOCSTRING} FORCE)
   MARK_AS_ADVANCED(MYSQL_PROJECT_NAME)
 ENDIF()
+
+# STRING(APPEND ...) from cmake VERSION 3.4
+MACRO(STRING_APPEND STRING_VAR INPUT)
+  SET(${STRING_VAR} "${${STRING_VAR}}${INPUT}")
+ENDMACRO()
+
+MACRO(STRING_PREPEND STRING_VAR INPUT)
+  SET(${STRING_VAR} "${INPUT}${${STRING_VAR}}")
+ENDMACRO()
+
 PROJECT(${MYSQL_PROJECT_NAME})
 
 # Maintainer mode is default on only for Linux debug builds using GCC/G++
@@ -479,6 +502,12 @@ IF(WITH_SYMVER16)
   ADD_DEFINITIONS(-DEXPORT_SYMVER16)
 ENDIF()
 
+# Disable -Werror=class-memaccess for gcc >= 8
+IF(CMAKE_COMPILER_IS_GNUCXX AND NOT GXX_VERSION VERSION_LESS 8)
+  STRING_APPEND(CMAKE_CXX_FLAGS_DEBUG          " -Wno-class-memaccess")
+  STRING_APPEND(CMAKE_CXX_FLAGS_RELWITHDEBINFO " -Wno-class-memaccess")
+ENDIF()
+
 IF(NOT WITHOUT_SERVER)
   SET (MYSQLD_STATIC_PLUGIN_LIBS "" CACHE INTERNAL "")
   # Add storage engines and plugins.

client/CMakeLists.txt

@@ -1,4 +1,4 @@
-# Copyright (c) 2006, 2018, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2006, 2019, Oracle and/or its affiliates. All rights reserved.
 # 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -26,9 +26,6 @@ INCLUDE_DIRECTORIES(
 )
 
 
-## We will need libeay32.dll and ssleay32.dll when running client executables.
-COPY_OPENSSL_DLLS(copy_openssl_client)
-
 ADD_DEFINITIONS(${SSL_DEFINES})
 MYSQL_ADD_EXECUTABLE(mysql completion_hash.cc mysql.cc readline.cc sql_string.cc)
 TARGET_LINK_LIBRARIES(mysql mysqlclient)

cmake/build_configurations/compiler_options.cmake

@@ -1,4 +1,4 @@
-# Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved.
 # 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -34,6 +34,12 @@ IF(UNIX)
     SET(CMAKE_C_FLAGS_RELWITHDEBINFO "-O3 ${COMMON_C_FLAGS}")
   ENDIF()
   IF(CMAKE_COMPILER_IS_GNUCXX)
+    # GCC 6 has C++14 as default, set it explicitly to the old default.
+    EXECUTE_PROCESS(COMMAND ${CMAKE_CXX_COMPILER} -dumpversion
+                    OUTPUT_VARIABLE GXX_VERSION)
+    IF(GXX_VERSION VERSION_EQUAL 6.0 OR GXX_VERSION VERSION_GREATER 6.0)
+      SET(COMMON_CXX_FLAGS             "${COMMON_CXX_FLAGS} -std=gnu++03")
+    ENDIF()
     SET(COMMON_CXX_FLAGS               "-g -fabi-version=2 -fno-omit-frame-pointer -fno-strict-aliasing")
     # Disable inline optimizations for valgrind testing to avoid false positives
     IF(WITH_VALGRIND)
@@ -51,6 +57,12 @@ IF(UNIX)
   ENDIF()
   IF(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     SET(COMMON_CXX_FLAGS               "-g -fno-omit-frame-pointer -fno-strict-aliasing")
+    IF(CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 6.0 OR
+        CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0)
+      IF(CMAKE_SYSTEM_NAME MATCHES "Linux")
+        SET(COMMON_CXX_FLAGS           "${COMMON_CXX_FLAGS} -std=gnu++03")
+      ENDIF()
+    ENDIF()
     SET(CMAKE_CXX_FLAGS_DEBUG          "${COMMON_CXX_FLAGS}")
     SET(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 ${COMMON_CXX_FLAGS}")
   ENDIF()

cmake/build_configurations/feature_set.cmake

@@ -1,4 +1,4 @@
-# Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved.
 # 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -77,5 +77,9 @@ IF(FEATURE_SET)
   ENDFOREACH()
 ENDIF()
 
-SET(WITH_SSL bundled CACHE STRING "")
-SET(WITH_ZLIB bundled CACHE STRING "")
+IF(NOT WITH_SSL)
+  SET(WITH_SSL bundled CACHE STRING "")
+ENDIF()
+IF(NOT WITH_ZLIB)
+  SET(WITH_ZLIB bundled CACHE STRING "")
+ENDIF()