Skip to content

Commit 77b0e69

Browse files
committed
Merge pull request #655 from ajaxorg/hotfix/metric_points
added metrics for live code inspection, settings saving and improved sav...
2 parents 8d7f414 + 91fa80a commit 77b0e69

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

client/ext/language/liveinspect.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,15 @@ module.exports = (function () {
1818
// get respective HTML elements
1919
windowHtml = winLiveInspect.$ext;
2020
datagridHtml = dgLiveInspect.$ext;
21+
winLiveInspect.addEventListener("prop.visible", function(e) {
22+
// don't track when hiding the window
23+
if (!e.value)
24+
return;
25+
ide.dispatchEvent("track_action", {
26+
type: "live inspect code",
27+
expression: currentExpression || "no expression available yet."
28+
});
29+
});
2130
};
2231

2332
var hook = function(_ext, worker) {

client/ext/save/save.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,11 @@ module.exports = ext.register("ext/save/save", {
273273

274274
panel.setAttribute("caption", "Saved file " + path);
275275
ide.dispatchEvent("afterfilesave", {node: node, doc: doc, value: value});
276-
ide.dispatchEvent("track_action", {type: "save as filetype", fileType: node.getAttribute("name").split(".").pop()});
276+
ide.dispatchEvent("track_action", {
277+
type: "save as filetype",
278+
fileType: node.getAttribute("name").split(".").pop(),
279+
success: state != apf.SUCCESS ? "false" : "true"
280+
});
277281

278282
apf.xmldb.removeAttribute(node, "saving");
279283
apf.xmldb.removeAttribute(node, "new");

client/ext/settings/settings.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,16 @@ module.exports = ext.register("ext/settings/settings", {
3939
},
4040

4141
saveToFile : function() {
42+
var data = this.model.data && apf.xmldb.cleanXml(this.model.data.xml) || "";
4243
ide.send(JSON.stringify({
4344
command: "settings",
4445
action: "set",
45-
settings: this.model.data && apf.xmldb.cleanXml(this.model.data.xml) || ""
46+
settings: data
4647
}));
48+
ide.dispatchEvent("track_action", {
49+
type: "save settings",
50+
settings: data
51+
});
4752
},
4853

4954
saveSettingsPanel: function() {

0 commit comments

Comments
 (0)