Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CameronHosking/subprocesscpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pnappa/subprocesscpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 13 commits
  • 1 file changed
  • 3 contributors

Commits on Nov 18, 2018

  1. just wrote down some of the function/class signatures of some of the … 

    …potential new API dealios
    @pnappa
    pnappa committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    010cc5a View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2018

  1. Merge pull request #3 from pnappa/new_api 

    syncing branch
    @CameronHosking
    CameronHosking authored Nov 19, 2018
    Configuration menu
    Copy the full SHA
    2bef28d View commit details
    Browse the repository at this point in the history

  2. add canReadLine method to TwoWayPipe, commented out new API, use iter… 

    …ators in Process
    @CameronHosking
    CameronHosking committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    b075630 View commit details
    Browse the repository at this point in the history

  3. fix over pessimistic canReadLine function

    @CameronHosking
    CameronHosking committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    49bed44 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. optimise so that a piped string will only be read over once. Fix inco… 

    …nsistency with isGood()

Previously both calls to readLine and canReadline would independently read the buffer on every call.
Now we don't reread the buffer where we already know there is no newline character.
Also put in a check to avoid double initialization of pipes
    @CameronHosking
    CameronHosking committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    f05d235 View commit details
    Browse the repository at this point in the history

  2. add timeout to ready check and readline

    @CameronHosking
    CameronHosking committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    c2e0a0e View commit details
    Browse the repository at this point in the history

  3. fix some formatting

    @CameronHosking
    CameronHosking committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    34f9214 View commit details
    Browse the repository at this point in the history

  4. move internal functions to private

    @CameronHosking
    CameronHosking committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    5a8c93c View commit details
    Browse the repository at this point in the history

  5. don't check if isGood() after checking isReady() 

    isReady can't return true if the pipe is not good so it is pointless to check
    @CameronHosking
    CameronHosking committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    a98c39c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. remove unnecessary wait code in Process

    @CameronHosking
    CameronHosking committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    fbd5a0e View commit details
    Browse the repository at this point in the history

  2. use more standard error checking code

    @CameronHosking
    CameronHosking committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    8b70a47 View commit details
    Browse the repository at this point in the history

  3. put TwoWayPipe and Process into internal namespace

    @CameronHosking
    CameronHosking committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    f15d66c View commit details
    Browse the repository at this point in the history

  4. Merge pull request pnappa#10 from CameronHosking/new_api_development 

    New api development
    @CameronHosking
    CameronHosking authored Nov 21, 2018
    Configuration menu
    Copy the full SHA
    cec20c8 View commit details
    Browse the repository at this point in the history
Loading