stringifyArguments handles undefined and null properly

Author: eriwen

stacktrace.js

@@ -154,21 +154,24 @@ printStackTrace.implementation.prototype = {
     stringifyArguments: function(args) {
         for (var i = 0; i < args.length; ++i) {
             var arg = args[i];
-            if (!arg || !arg.constructor) {
-                return;
-            }
-            if (arg.constructor === Array) {
-                if (arg.length < 3) {
-                    args[i] = '[' + this.stringifyArguments(arg) + ']';
-                } else {
-                    args[i] = '[' + this.stringifyArguments(Array.prototype.slice.call(arg, 0, 1)) + '...' + this.stringifyArguments(Array.prototype.slice.call(arg, -1)) + ']';
+            if (arg === undefined) {
+                args[i] = 'undefined';
+            } else if (arg === null) {
+                args[i] = 'null';
+            } else if (arg.constructor) {
+                if (arg.constructor === Array) {
+                    if (arg.length < 3) {
+                        args[i] = '[' + this.stringifyArguments(arg) + ']';
+                    } else {
+                        args[i] = '[' + this.stringifyArguments(Array.prototype.slice.call(arg, 0, 1)) + '...' + this.stringifyArguments(Array.prototype.slice.call(arg, -1)) + ']';
+                    }
+                } else if (arg.constructor === Object) {
+                    args[i] = '#object';
+                } else if (arg.constructor === Function) {
+                    args[i] = '#function';
+                } else if (arg.constructor === String) {
+                    args[i] = '"' + arg + '"';
                 }
-            } else if (arg.constructor === Object) {
-                args[i] = '#object';
-            } else if (arg.constructor === Function) {
-                args[i] = '#function';
-            } else if (arg.constructor === String) {
-                args[i] = '"' + arg + '"';
             }
         }
         return args.join(',');

test-stacktrace.js

@@ -208,9 +208,9 @@ test("recursion other", function() {
 
 test("stringify", function() {
     expect(5);
-    equals(printStackTrace.implementation.prototype.stringifyArguments(["a", 1, {}, function() {}]), '"a",1,#object,#function');
-    equals(printStackTrace.implementation.prototype.stringifyArguments([1, 2, 3]), '1,2,3');
-    equals(printStackTrace.implementation.prototype.stringifyArguments([['a', 'b']]), '["a","b"]');
+    equals(printStackTrace.implementation.prototype.stringifyArguments(["a", 1, {}, function() {}, undefined]), '"a",1,#object,#function,undefined');
+    equals(printStackTrace.implementation.prototype.stringifyArguments([0, 1, 2, 3]), '0,1,2,3');
+    equals(printStackTrace.implementation.prototype.stringifyArguments([['a', null]]), '["a",null]');
     equals(printStackTrace.implementation.prototype.stringifyArguments([[2, 4, 6, 8, 10, 12, 14]]), '[2...14]');
     equals(printStackTrace.implementation.prototype.stringifyArguments([]), '');
 });