Skip to content

Commit 24e5a90

Browse files
authored
Revert "Parallelize TensorMethods.cpp builds (pytorch#1364)" (pytorch#1390)
This reverts commit 060048b.
1 parent 060048b commit 24e5a90

File tree

6 files changed

+18
-71
lines changed

6 files changed

+18
-71
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ torch/csrc/nn/THCUNN.cpp
1919
torch/csrc/nn/THNN_generic.cwrap
2020
torch/csrc/nn/THNN_generic.cpp
2121
torch/csrc/nn/THNN_generic.h
22-
torch/csrc/generated
2322
docs/src/**/*
2423
test/data/legacy_modules.t7
2524
test/data/gpu_tensors.pt

setup.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
from tools.setup_helpers.env import check_env_flag
1616
from tools.setup_helpers.cuda import WITH_CUDA, CUDA_HOME
1717
from tools.setup_helpers.cudnn import WITH_CUDNN, CUDNN_LIB_DIR, CUDNN_INCLUDE_DIR
18-
from tools.setup_helpers.split_types import split_types
1918
DEBUG = check_env_flag('DEBUG')
2019
WITH_DISTRIBUTED = check_env_flag('WITH_DISTRIBUTED')
2120
WITH_DISTRIBUTED_MW = WITH_DISTRIBUTED and check_env_flag('WITH_DISTRIBUTED_MW')
@@ -260,6 +259,7 @@ def run(self):
260259
"torch/csrc/Generator.cpp",
261260
"torch/csrc/Size.cpp",
262261
"torch/csrc/Exceptions.cpp",
262+
"torch/csrc/Tensor.cpp",
263263
"torch/csrc/Storage.cpp",
264264
"torch/csrc/DynamicTypes.cpp",
265265
"torch/csrc/byte_order.cpp",
@@ -282,7 +282,6 @@ def run(self):
282282
"torch/csrc/autograd/functions/convolution.cpp",
283283
"torch/csrc/autograd/functions/init.cpp",
284284
"torch/csrc/nn/THNN_generic.cpp",
285-
*split_types("torch/csrc/Tensor.cpp")
286285
]
287286

288287
try:
@@ -326,10 +325,10 @@ def run(self):
326325
"torch/csrc/cuda/Module.cpp",
327326
"torch/csrc/cuda/Storage.cpp",
328327
"torch/csrc/cuda/Stream.cpp",
328+
"torch/csrc/cuda/Tensor.cpp",
329329
"torch/csrc/cuda/AutoGPU.cpp",
330330
"torch/csrc/cuda/utils.cpp",
331331
"torch/csrc/cuda/serialization.cpp",
332-
*split_types("torch/csrc/cuda/Tensor.cpp"),
333332
]
334333

335334
if WITH_NCCL:

tools/setup_helpers/split_types.py

Lines changed: 0 additions & 57 deletions
This file was deleted.

torch/csrc/Tensor.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,12 @@
99
#include <tuple>
1010
#include <TH/THMath.h>
1111

12-
#include "torch/csrc/THP.h"
13-
#include "torch/csrc/copy_utils.h"
14-
#include "torch/csrc/DynamicTypes.h"
12+
#include "THP.h"
13+
#include "copy_utils.h"
14+
#include "DynamicTypes.h"
1515

16-
//generic_include TH torch/csrc/generic/Tensor.cpp
16+
#include "generic/Tensor.cpp"
17+
#include <TH/THGenerateAllTypes.h>
18+
19+
#include "generic/Tensor.cpp"
20+
#include <TH/THGenerateHalfType.h>

torch/csrc/cuda/Tensor.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,14 @@
66
#include <vector>
77
#include <stack>
88
#include <tuple>
9-
#include "torch/csrc/cuda/THCP.h"
9+
#include "THCP.h"
1010

11-
#include "torch/csrc/cuda/override_macros.h"
11+
#include "override_macros.h"
1212
#include "torch/csrc/copy_utils.h"
1313
#include "DynamicTypes.h"
1414

15-
//generic_include THC torch/csrc/generic/Tensor.cpp
15+
#define THC_GENERIC_FILE "torch/csrc/generic/Tensor.cpp"
16+
#include <THC/THCGenerateAllTypes.h>
1617

17-
#include "torch/csrc/cuda/undef_macros.h"
18-
#include "torch/csrc/cuda/restore_macros.h"
18+
#include "undef_macros.h"
19+
#include "restore_macros.h"

torch/csrc/generic/methods/TensorMath.cwrap

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1625,7 +1625,8 @@
16251625
- THTensor* tensor2
16261626
]]
16271627

1628-
#if defined(TH_REAL_IS_FLOAT) || defined(TH_REAL_IS_DOUBLE) || CUDA_FLOAT || CUDA_DOUBLE
1628+
#ifndef THP_LAPACK_CONSTANTS
1629+
#define THP_LAPACK_CONSTANTS
16291630
// We need to pass pointers to chars to tensor lapack functions...
16301631
static const char __U = 'U';
16311632
static const char __L = 'L';

0 commit comments

Comments
 (0)