fixing unit tests for route53 plugin

Author: György Demarcsek

tests/plugins/test_route53.py

@@ -54,11 +54,6 @@ class Route53ChangedDoesNotExist(unittest.TestCase):
     @patch('plugins.route53.urllib2')
     def test_run(self, mock_urllib2):
         import re
-        does_not_exist_regexes = [
-            re.compile(r"NoSuchBucket|NoSuchKey|NoSuchVersion"),  # NoSuch error messages from S3
-            re.compile(r"[Ee]xpir(ed|y|es)"),  # expiry messages
-            re.compile(r"not exists?")  # generic does not exist
-        ]
 
         def mocked_get_location_content(location, *args, **kwargs):
             if location == "https://prezi.com/nosuch1":
@@ -69,12 +64,12 @@ def mocked_get_location_content(location, *args, **kwargs):
                 return MagicMock(read=MagicMock(side_effect=lambda: "this page does not exist"))
 
         mock_urllib2.urlopen = MagicMock(side_effect=mocked_get_location_content)
-        results = list(page_process_for_route53changed('https://prezi.com/nosuch1', does_not_exist_regexes))
-        self.assertEquals(set(['NoSuchBucket|NoSuchKey|NoSuchVersion']), results[1]["matches"])
-        results = list(page_process_for_route53changed('https://meh.prezi.com', does_not_exist_regexes))
-        self.assertEquals(set([]), results[1]["matches"])
-        results = list(page_process_for_route53changed('https://my404.prezi.com', does_not_exist_regexes))
-        self.assertEquals(set(["not exists?"]), results[1]["matches"])
+        results = list(page_process_for_route53changed('https://prezi.com/nosuch1'))
+        self.assertEquals(['NoSuchBucket|NoSuchKey|NoSuchVersion'], results[1]["matches"])
+        results = list(page_process_for_route53changed('https://meh.prezi.com'))
+        self.assertEquals([], results[1]["matches"])
+        results = list(page_process_for_route53changed('https://my404.prezi.com'))
+        self.assertEquals(["not exists?"], results[1]["matches"])
 
 
 def main():