Make sure modifiers are in JLS order

Author: britter

checkstyle.xml

@@ -46,6 +46,7 @@ limitations under the License.
       <property name="allowUndeclaredRTE" value="true"/>
       <property name="scope" value="public" />
     </module>
+    <module name="ModifierOrder"/>
     <module name="UpperEll" />
  </module>
 </module>

src/main/java/org/apache/commons/lang3/ThreadUtils.java

@@ -272,7 +272,7 @@ public interface ThreadGroupPredicate /*extends java.util.function.Predicate<Thr
     /**
      * A predicate implementation which always returns true.
      */
-    private final static class AlwaysTruePredicate implements ThreadPredicate, ThreadGroupPredicate{
+    private static final class AlwaysTruePredicate implements ThreadPredicate, ThreadGroupPredicate{
 
         private AlwaysTruePredicate() {
         }

src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java

@@ -244,7 +244,7 @@ public synchronized Future<T> getFuture() {
      *
      * @return the {@code ExecutorService} for executing the background task
      */
-    protected synchronized final ExecutorService getActiveExecutor() {
+    protected final synchronized ExecutorService getActiveExecutor() {
         return executor;
     }
 

src/main/java/org/apache/commons/lang3/concurrent/ThresholdCircuitBreaker.java

@@ -55,7 +55,7 @@ public class ThresholdCircuitBreaker extends AbstractCircuitBreaker<Long> {
     /**
      * The initial value of the internal counter.
      */
-    private final static long INITIAL_COUNT = 0L;
+    private static final long INITIAL_COUNT = 0L;
 
     /**
      * The threshold.

src/main/java/org/apache/commons/lang3/time/FastDateParser.java

@@ -201,7 +201,7 @@ int getMaxWidth(final ListIterator<StrategyAndWidth> lt) {
      * Parse format into Strategies
      */
     private class StrategyParser {
-        final private Calendar definingCalendar;
+        private final Calendar definingCalendar;
         private int currentIdx;
 
         StrategyParser(final Calendar definingCalendar) {
@@ -491,7 +491,7 @@ private int adjustYear(final int twoDigitYear) {
     /**
      * A strategy to parse a single field from the parsing pattern
      */
-    private static abstract class Strategy {
+    private abstract static class Strategy {
         /**
          * Is this field a number?
          * The default implementation returns false.
@@ -508,7 +508,7 @@ boolean isNumber() {
     /**
      * A strategy to parse a single field from the parsing pattern
      */
-    private static abstract class PatternStrategy extends Strategy {
+    private abstract static class PatternStrategy extends Strategy {
 
         private Pattern pattern;
 
@@ -648,7 +648,7 @@ private Strategy getLocaleSpecificStrategy(final int field, final Calendar defin
      */
     private static class CopyQuotedStrategy extends Strategy {
 
-        final private String formatField;
+        private final String formatField;
 
         /**
          * Construct a Strategy that ensures the formatField has literal text

src/main/java/org/apache/commons/lang3/time/FormatCache.java

@@ -101,7 +101,7 @@ public F getInstance(final String pattern, TimeZone timeZone, Locale locale) {
      * @throws IllegalArgumentException if pattern is invalid
      *  or <code>null</code>
      */
-    abstract protected F createInstance(String pattern, TimeZone timeZone, Locale locale);
+    protected abstract F createInstance(String pattern, TimeZone timeZone, Locale locale);
 
     /**
      * <p>Gets a date/time formatter instance using the specified style,

src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java

@@ -137,7 +137,7 @@ public String toString(){
             new TestData("Abcd",false,     1,     "abcD",1,     2,     true),
     };
 
-    private static abstract class RunTest {
+    private abstract static class RunTest {
 
         abstract boolean invoke();
 

src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java

@@ -56,13 +56,14 @@ Sun Microsystems Inc. Java HotSpot(TM) Server VM 1.4.2_04-b05
 
  */
 public class CharUtilsPerfRun {
-    final static String VERSION = "$Id$";
+    private static final String VERSION = "$Id$";
 
-    final static int WARM_UP = 100;
+    private static final int WARM_UP = 100;
 
-    final static int COUNT = 5000;
+    private static final int COUNT = 5000;
+
+    private static final char[] CHAR_SAMPLES;
 
-    final static char[] CHAR_SAMPLES;
     static {
         CHAR_SAMPLES = new char[Character.MAX_VALUE];
         for (char i = Character.MIN_VALUE; i < Character.MAX_VALUE; i++) {

src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java

@@ -40,7 +40,7 @@
  */
 @Deprecated
 public class StringEscapeUtilsTest {
-    private final static String FOO = "foo";
+    private static final String FOO = "foo";
 
     @Test
     public void testConstructor() {

src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java

@@ -109,7 +109,7 @@ static class TestSubObject extends TestObject {
         private int b;
 
         @SuppressWarnings("unused")
-        transient private int t;
+        private transient int t;
 
         public TestSubObject() {
             super(0);