Skip to content

Commit 3a74d4f

Browse files
committed
networkd-ndisc: do not return value from void function
Fixup for systemd#3304. Only warn, and not return, because that's what sd_dhcp6_client_start() does right below the call to sd_dhcp6_client_set_local_address().
1 parent 469978a commit 3a74d4f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/network/networkd-ndisc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ static void ndisc_router_handler(sd_ndisc *nd, uint8_t flags, const struct in6_a
159159

160160
r = sd_dhcp6_client_set_local_address(link->dhcp6_client, &link->ipv6ll_address);
161161
if (r < 0 && r != -EBUSY)
162-
return log_link_warning_errno(link, r, "Could not set IPv6LL address in DHCP client: %m");
162+
log_link_warning_errno(link, r, "Could not set IPv6LL address in DHCP client: %m");
163163

164164
r = sd_dhcp6_client_start(link->dhcp6_client);
165165
if (r < 0 && r != -EBUSY)
@@ -209,7 +209,7 @@ static void ndisc_handler(sd_ndisc *nd, int event, void *userdata) {
209209

210210
r = sd_dhcp6_client_set_local_address(link->dhcp6_client, &link->ipv6ll_address);
211211
if (r < 0 && r != -EBUSY)
212-
return log_link_warning_errno(link, r, "Could not set IPv6LL address in DHCP client: %m");
212+
log_link_warning_errno(link, r, "Could not set IPv6LL address in DHCP client: %m");
213213

214214
r = sd_dhcp6_client_start(link->dhcp6_client);
215215
if (r < 0 && r != -EBUSY)

0 commit comments

Comments
 (0)