Add transform_labels to Transform, Simplex, SumTo1, and ZeroSum #7907 #7975
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented transform_labels method to handle coordinate transformations.
Verified via existing test suite and manual verification script.
Description
This PR addresses Issue #7907 by adding a
transform_labelsmethod to the baseTransformclass and overriding it in specific subclasses. This ensures that when transformations (like Simplex) reduce the dimensionality of the data, the associated coordinates/labels are adjusted accordingly.Changes implemented:
Transform: Addedtransform_labelswhich returns labels unchanged (identity).SimplexTransform: Overridden to returnlabels[:-1](dropping the last label).SumTo1: Overridden to returnlabels[:-1].ZeroSumTransform: Overridden to handlezerosum_axes, ensuring the last label is dropped for the specific axes being transformed.Related Issue
transform_coordsmethod toTransformmethod to automatically label unconstrained draws #7907Checklist
Type of change