ignite.engines -> ignite.engine

[alykhantejani]

resolve #152

cc @vfdev-5 @jasonkriss can I get a review please :)

[vfdev-5]

LGTM, let's wait travis

[alykhantejani]

yeah, or the alternative is to put the things in `__init__.py` into `ignite/engine.py` 🤷

…

On Wed, Apr 25, 2018 at 4:03 PM, vfdev ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In ignite/engine/__init__.py <#158 (comment)>: > @@ -1,4 +1,4 @@ -from ignite.engines.engine import Engine, Events, State +from .engine import Engine, State, Events from ignite.engine.engine import Engine we should have called the package engine to complete the similarity :) Otherwise, if you put Engine, State, Event into ignite.__init__.py it could be nicer, what do you think ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAp8WiE-ZzzH_f7Ip6HE30aEM14dqXNKks5tsJAkgaJpZM4TjaUB> .

[jasonkriss]

LGTM!

[vfdev-5]

@alykhantejani as you are working on this, could you fix also logger messages in Engine as it is not a trainer anymore:

• "Training starting with max_epochs={}", maybe, by "Engine run starting with max_epochs={}"
• "Training complete. Time taken %02d:%02d:%02d" by "Engine run complete. Time taken %02d:%02d:%02d"
• "Training is terminating due to exception: %s" by "Engine run is terminating due to exception: %s"

Thanks

[alykhantejani]

@vfdev-5 sure thing. Was waiting to merge the other PRs so others don't have to fix merge conflicts :)

[vfdev-5]

@alykhantejani just remarked, maybe, we need to change test/ignite/engineS to test/ignite/engine ?

[alykhantejani]

Yup - my bad.