WL#12671 Change named_pipe_full_access_group default on Windows

RB: 25507
Reviewed by Georgi Kodinov <[email protected]>
Reviewed by Ivo Roylev <[email protected]>

Author: Daniel Blanchard

mysql-test/r/mysqld--help-win.result

@@ -1187,7 +1187,7 @@ myisam-sort-buffer-size 8388608
 myisam-stats-method nulls_unequal
 myisam-use-mmap FALSE
 named-pipe FALSE
-named-pipe-full-access-group *everyone*
+named-pipe-full-access-group 
 net-buffer-length 16384
 net-read-timeout 30
 net-retry-count 10

mysql-test/suite/sys_vars/r/named_pipe_full_access_group_basic.result

@@ -1,14 +1,14 @@
 select @@global.named_pipe_full_access_group;
 @@global.named_pipe_full_access_group
-*everyone*
+
 select @@session.named_pipe_full_access_group;
 ERROR HY000: Variable 'named_pipe_full_access_group' is a GLOBAL variable
 show global variables like 'named_pipe_full_access_group';
 Variable_name	Value
-named_pipe_full_access_group	*everyone*
+named_pipe_full_access_group	
 show session variables like 'named_pipe_full_access_group';
 Variable_name	Value
-named_pipe_full_access_group	*everyone*
+named_pipe_full_access_group	
 set global named_pipe_full_access_group = NULL;
 show session variables like 'named_pipe_full_access_group';
 Variable_name	Value
@@ -22,3 +22,4 @@ NAMED_PIPE_FULL_ACCESS_GROUP	*everyone*
 select * from information_schema.session_variables where variable_name='named_pipe_full_access_group';
 VARIABLE_NAME	VARIABLE_VALUE
 NAMED_PIPE_FULL_ACCESS_GROUP	*everyone*
+set global named_pipe_full_access_group = default;

mysql-test/suite/sys_vars/t/named_pipe_full_access_group_basic.test

@@ -15,4 +15,6 @@ set global named_pipe_full_access_group = '*everyone*';
 select * from information_schema.global_variables where variable_name='named_pipe_full_access_group';
 select * from information_schema.session_variables where variable_name='named_pipe_full_access_group';
 --enable_warnings
+# Restore initial state
+set global named_pipe_full_access_group = default;
 

sql/named_pipe.cc

@@ -69,7 +69,7 @@ static bool check_windows_group_for_everyone(const char *group_name,
     return false;
   }
 
-  if (strcmp(group_name, DEFAULT_NAMED_PIPE_FULL_ACCESS_GROUP) == 0)
+  if (strcmp(group_name, NAMED_PIPE_FULL_ACCESS_GROUP_EVERYONE) == 0)
   {
     *is_everyone_group= true;
     return false;
@@ -160,9 +160,9 @@ bool my_security_attr_add_rights_to_group(SECURITY_ATTRIBUTES *psa,
     }
   }
 
-  // Treat the DEFAULT_NAMED_PIPE_FULL_ACCESS_GROUP value
+  // Treat the NAMED_PIPE_FULL_ACCESS_GROUP_EVERYONE value
   // as a special case: we  convert it to the "world" SID
-  if (strcmp(group_name, DEFAULT_NAMED_PIPE_FULL_ACCESS_GROUP) == 0)
+  if (strcmp(group_name, NAMED_PIPE_FULL_ACCESS_GROUP_EVERYONE) == 0)
   {
     if (!CreateWellKnownSid(WinWorldSid, NULL, soughtSID, &size_sid))
     {

sql/named_pipe.h

@@ -41,5 +41,6 @@ bool is_valid_named_pipe_full_access_group(const char *group_name);
 bool my_security_attr_add_rights_to_group(SECURITY_ATTRIBUTES *psa,
                                           const char *group_name,
                                           DWORD group_rights);
-#define DEFAULT_NAMED_PIPE_FULL_ACCESS_GROUP "*everyone*"
+#define DEFAULT_NAMED_PIPE_FULL_ACCESS_GROUP ""
+#define NAMED_PIPE_FULL_ACCESS_GROUP_EVERYONE "*everyone*"
 #endif /* NAMED_PIPE_INCLUDED */