Skip to content

Conversation

@rafeyrana
Copy link
Contributor

fixes #245

  • Update docs/user_guides/quick_start.md to reflect the new token format.
  • Update tests/conftest.py to change the cassette Authorization default masked token.

@codecov
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d07ce47) to head (d768db9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          304       304           
=========================================
  Hits           304       304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramnes
Copy link
Owner

ramnes commented Dec 28, 2024

Thanks! We need to recreate the cassettes as well, so that the conftest change is actually reflected. Feel free to do it it not, I'll do it myself later if needed. :)

@rafeyrana
Copy link
Contributor Author

No worries! I will do it and submit the PR

@rafeyrana
Copy link
Contributor Author

Hi @ramnes I have tried to recreate the cassettes to make sure the conftest change is reflected but i'm running into some issues particularly with the delete block and page tests:

image

For reference I have created a private integration with all content settings enabled to allow full access.

image

I have narrowed the issue down to the previously created blocks and pages not being properly cleaned up. The blocks / pages are being archived / deleted before being deleted the testing functions are called on them.

Upon running the tests without the cassettes on the main branch with my integration, I think it has something to do with the way I am setting up my new integration. I have never created an integration before but for some reason the issue persists in the 3 different private integrations I have tried to build to test this over 2 accounts.

You may recreate the cassettes on your end if easier but i would appreciate an explanation on what I have been getting wrong.

@ramnes
Copy link
Owner

ramnes commented Dec 29, 2024

Actually it looks like you did everything right. Maybe something changed on Notion's side since we generated the current cassettes and we need to update the tests as well. Again, feel free to do it or not. :)

@ramnes
Copy link
Owner

ramnes commented Dec 30, 2024

I fixed the tests in #248. We had errors because apparently Notion doesn't allow anymore to delete a page or block that has already been deleted, which we used to do when testing deletion: we were deleting once in the test itself, and once in the fixture teardown.

I went ahead and pushed new commits to merge the fix and regenerate the cassettes with your changes. Merging now, thanks!

@ramnes ramnes merged commit aa71fec into ramnes:main Dec 30, 2024
8 checks passed
@rafeyrana
Copy link
Contributor Author

Perfect thanks. Will continue to keep working on the sdk with you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token format update: secret_ntn_

2 participants