-
-
Notifications
You must be signed in to change notification settings - Fork 165
Token format update: secret_ → ntn_ #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 304 304
=========================================
Hits 304 304 ☔ View full report in Codecov by Sentry. |
|
Thanks! We need to recreate the cassettes as well, so that the conftest change is actually reflected. Feel free to do it it not, I'll do it myself later if needed. :) |
|
No worries! I will do it and submit the PR |
|
Hi @ramnes I have tried to recreate the cassettes to make sure the conftest change is reflected but i'm running into some issues particularly with the delete block and page tests:
For reference I have created a private integration with all content settings enabled to allow full access.
I have narrowed the issue down to the previously created blocks and pages not being properly cleaned up. The blocks / pages are being archived / deleted before being deleted the testing functions are called on them. Upon running the tests without the cassettes on the main branch with my integration, I think it has something to do with the way I am setting up my new integration. I have never created an integration before but for some reason the issue persists in the 3 different private integrations I have tried to build to test this over 2 accounts. You may recreate the cassettes on your end if easier but i would appreciate an explanation on what I have been getting wrong. |
|
Actually it looks like you did everything right. Maybe something changed on Notion's side since we generated the current cassettes and we need to update the tests as well. Again, feel free to do it or not. :) |
|
I fixed the tests in #248. We had errors because apparently Notion doesn't allow anymore to delete a page or block that has already been deleted, which we used to do when testing deletion: we were deleting once in the test itself, and once in the fixture teardown. I went ahead and pushed new commits to merge the fix and regenerate the cassettes with your changes. Merging now, thanks! |
|
Perfect thanks. Will continue to keep working on the sdk with you!! |


fixes #245
docs/user_guides/quick_start.mdto reflect the new token format.tests/conftest.pyto change the cassette Authorization default masked token.