update metrics functions :

 - remove returned object, not used
 - remove addTcpConnection function, not used

Author: nicosang

src/streaming/models/MetricsModel.js

@@ -31,7 +31,6 @@
 import Constants from '../constants/Constants';
 import MetricsConstants from '../constants/MetricsConstants';
 import MetricsList from '../vo/MetricsList';
-import TCPConnection from '../vo/metrics/TCPConnection';
 import {HTTPRequest, HTTPRequestTrace} from '../vo/metrics/HTTPRequest';
 import TrackSwitch from '../vo/metrics/RepresentationSwitch';
 import BufferLevel from '../vo/metrics/BufferLevel';
@@ -121,20 +120,6 @@ function MetricsModel() {
         }
     }
 
-    function addTcpConnection(mediaType, tcpid, dest, topen, tclose, tconnect) {
-        let vo = new TCPConnection();
-
-        vo.tcpid = tcpid;
-        vo.dest = dest;
-        vo.topen = topen;
-        vo.tclose = tclose;
-        vo.tconnect = tconnect;
-
-        pushAndNotify(mediaType, MetricsConstants.TCP_CONNECTION, vo);
-
-        return vo;
-    }
-
     function appendHttpTrace(httpRequest, s, d, b) {
         let vo = new HTTPRequestTrace();
 
@@ -211,8 +196,6 @@ function MetricsModel() {
         }
 
         pushAndNotify(mediaType, MetricsConstants.HTTP_REQUEST, vo);
-
-        return vo;
     }
 
     function addRepresentationSwitch(mediaType, t, mt, to, lto) {
@@ -229,8 +212,6 @@ function MetricsModel() {
         }
 
         pushAndNotify(mediaType, MetricsConstants.TRACK_SWITCH, vo);
-
-        return vo;
     }
 
     function pushAndNotify(mediaType, metricType, metricObject) {
@@ -244,8 +225,6 @@ function MetricsModel() {
         vo.level = level;
 
         pushAndNotify(mediaType, MetricsConstants.BUFFER_LEVEL, vo);
-
-        return vo;
     }
 
     function addBufferState(mediaType, state, target) {
@@ -254,8 +233,6 @@ function MetricsModel() {
         vo.state = state;
 
         pushAndNotify(mediaType, MetricsConstants.BUFFER_STATE, vo);
-
-        return vo;
     }
 
     function addDVRInfo(mediaType, currentTime, mpd, range) {
@@ -265,8 +242,6 @@ function MetricsModel() {
         vo.manifestInfo = mpd;
 
         pushAndNotify(mediaType, MetricsConstants.DVR_INFO, vo);
-
-        return vo;
     }
 
     function addDroppedFrames(mediaType, quality) {
@@ -277,12 +252,10 @@ function MetricsModel() {
         vo.droppedFrames = quality.droppedVideoFrames;
 
         if (list.length > 0 && list[list.length - 1] == vo) {
-            return list[list.length - 1];
+            return;
         }
 
         pushAndNotify(mediaType, MetricsConstants.DROPPED_FRAMES, vo);
-
-        return vo;
     }
 
     function addSchedulingInfo(mediaType, t, type, startTime, availabilityStartTime, duration, quality, range, state) {
@@ -301,8 +274,6 @@ function MetricsModel() {
         vo.state = state;
 
         pushAndNotify(mediaType, MetricsConstants.SCHEDULING_INFO, vo);
-
-        return vo;
     }
 
     function addRequestsQueue(mediaType, loadingRequests, executedRequests) {
@@ -330,8 +301,6 @@ function MetricsModel() {
 
         pushMetrics(Constants.STREAM, MetricsConstants.MANIFEST_UPDATE, vo);
         metricAdded(mediaType, MetricsConstants.MANIFEST_UPDATE, vo);
-
-        return vo;
     }
 
     function updateManifestUpdateInfo(manifestUpdate, updatedFields) {
@@ -355,10 +324,7 @@ function MetricsModel() {
 
             manifestUpdate.streamInfo.push(vo);
             metricUpdated(manifestUpdate.mediaType, MetricsConstants.MANIFEST_UPDATE_STREAM_INFO, manifestUpdate);
-
-            return vo;
         }
-        return null;
     }
 
     function addManifestUpdateRepresentationInfo(manifestUpdate, id, index, streamIndex, mediaType, presentationTimeOffset, startNumber, fragmentInfoType) {
@@ -375,10 +341,7 @@ function MetricsModel() {
 
             manifestUpdate.representationInfo.push(vo);
             metricUpdated(manifestUpdate.mediaType, MetricsConstants.MANIFEST_UPDATE_TRACK_INFO, manifestUpdate);
-
-            return vo;
         }
-        return null;
     }
 
     function addPlayList(vo) {
@@ -395,24 +358,19 @@ function MetricsModel() {
         }
 
         pushAndNotify(type, MetricsConstants.PLAY_LIST, vo);
-
-        return vo;
     }
 
     function addDVBErrors(vo) {
         let type = Constants.STREAM;
 
         pushAndNotify(type, MetricsConstants.DVB_ERRORS, vo);
-
-        return vo;
     }
 
     instance = {
         clearCurrentMetricsForType: clearCurrentMetricsForType,
         clearAllCurrentMetrics: clearAllCurrentMetrics,
         getReadOnlyMetricsFor: getReadOnlyMetricsFor,
         getMetricsFor: getMetricsFor,
-        addTcpConnection: addTcpConnection,
         addHttpRequest: addHttpRequest,
         addRepresentationSwitch: addRepresentationSwitch,
         addBufferLevel: addBufferLevel,