feat: effect observables

Author: josepot

package-lock.json

@@ -22,7 +22,7 @@ require("esbuild")
       : "./dist/core.cjs.development.js",
     target: "es2015",
     minify: isProd,
-    external: ["react", "rxjs", "@rxstate/core", "use-sync-external-store"],
+    external: ["react", "rxjs", "@rx-state/core", "use-sync-external-store"],
     format: "cjs",
     sourcemap: true,
     plugins: [fixCjsPlugin],

packages/core/cjsBuild.js

@@ -1,5 +1,5 @@
 {
-  "version": "0.9.8",
+  "version": "0.10.0-rc.3",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/re-rxjs/react-rxjs.git"
@@ -25,8 +25,8 @@
   ],
   "scripts": {
     "build": "npm run build:ts && npm run build:esm2017 && npm run build:esm2019 && npm run build:cjs:dev && npm run build:cjs:prod",
-    "build:esm2019": "esbuild src/index.tsx --bundle --outfile=./dist/core.es2019.mjs --target=es2019 --external:react --external:rxjs --external:@rxstate/core --external:use-sync-external-store --format=esm --sourcemap",
-    "build:esm2017": "esbuild src/index.tsx --bundle --outfile=./dist/core.es2017.js --target=es2017 --external:react --external:rxjs --external:@rxstate/core --external:use-sync-external-store --format=esm --sourcemap",
+    "build:esm2019": "esbuild src/index.tsx --bundle --outfile=./dist/core.es2019.mjs --target=es2019 --external:react --external:rxjs --external:@rx-state/core --external:use-sync-external-store --format=esm --sourcemap",
+    "build:esm2017": "esbuild src/index.tsx --bundle --outfile=./dist/core.es2017.js --target=es2017 --external:react --external:rxjs --external:@rx-state/core --external:use-sync-external-store --format=esm --sourcemap",
     "build:cjs:dev": "node cjsBuild.js",
     "build:cjs:prod": "node cjsBuild.js --prod",
     "build:ts": "tsc -p ./tsconfig-build.json --outDir ./dist --skipLibCheck --emitDeclarationOnly",
@@ -50,7 +50,7 @@
     "Victor Oliva (https://github.com/voliva)"
   ],
   "dependencies": {
-    "@rxstate/core": "^0.0.1",
+    "@rx-state/core": "0.1.0-rc.3",
     "use-sync-external-store": "^1.0.0"
   },
   "devDependencies": {

packages/core/package.json

@@ -1,4 +1,4 @@
-import { state } from "@rxstate/core"
+import { state } from "@rx-state/core"
 import { render, screen, act } from "@testing-library/react"
 import React, { StrictMode, useState, useEffect } from "react"
 import { defer, EMPTY, NEVER, Observable, of, startWith } from "rxjs"

packages/core/src/SUSPENSE.ts

@@ -1,7 +1,11 @@
 import { Observable } from "rxjs"
-import { SUSPENSE } from "../SUSPENSE"
 import { EMPTY_VALUE } from "../internal/empty-value"
-import { state, StateObservable } from "@rxstate/core"
+import {
+  EffectObservable,
+  state,
+  StateObservable,
+  SUSPENSE,
+} from "@rx-state/core"
 import { useStateObservable } from "../useStateObservable"
 
 /**
@@ -23,12 +27,12 @@ import { useStateObservable } from "../useStateObservable"
  * subscription, then the hook will leverage React Suspense while it's waiting
  * for the first value.
  */
-export default function connectFactoryObservable<A extends [], O>(
-  getObservable: (...args: A) => Observable<O>,
+export default function connectFactoryObservable<A extends [], O, E>(
+  getObservable: (...args: A) => EffectObservable<O, E>,
   defaultValue: O | ((...args: A) => O),
 ): [
-  (...args: A) => Exclude<O, typeof SUSPENSE>,
-  (...args: A) => StateObservable<O>,
+  (...args: A) => Exclude<O | E, SUSPENSE>,
+  (...args: A) => StateObservable<O, E>,
 ] {
   const args:
     | [(...args: A) => Observable<O>]
@@ -37,6 +41,6 @@ export default function connectFactoryObservable<A extends [], O>(
       ? [getObservable]
       : [getObservable, defaultValue]
 
-  const obs = state(...(args as [(...args: A) => Observable<O>]))
+  const obs = state(...(args as [(...args: A) => EffectObservable<O, E>]))
   return [(...input: A) => useStateObservable(obs(...input)), obs]
 }

packages/core/src/Subscribe.test.tsx

@@ -477,7 +477,7 @@ describe("connectObservable", () => {
   it("allows async errors to be caught in error boundaries with suspense", async () => {
     const errStream = new Subject()
     const [useError, errStream$] = bind(errStream)
-    const errStream$WithoutErrors = errStream$.pipe(catchError(() => EMPTY))
+    const errStream$WithoutErrors = errStream$.pipe(catchError(() => NEVER))
 
     const ErrorComponent = () => {
       const value = useError()

packages/core/src/bind/connectFactoryObservable.ts

@@ -1,7 +1,7 @@
 import { EMPTY_VALUE } from "../internal/empty-value"
 import { Observable } from "rxjs"
 import { useStateObservable } from "../useStateObservable"
-import { state } from "@rxstate/core"
+import { state } from "@rx-state/core"
 
 /**
  * Accepts: An Observable.

packages/core/src/bind/connectObservable.test.tsx

@@ -1,9 +1,12 @@
 import { Observable } from "rxjs"
-import { SUSPENSE } from "../SUSPENSE"
 import connectFactoryObservable from "./connectFactoryObservable"
 import connectObservable from "./connectObservable"
 import { EMPTY_VALUE } from "../internal/empty-value"
-import { StateObservable, DefaultedStateObservable } from "@rxstate/core"
+import {
+  StateObservable,
+  DefaultedStateObservable,
+  SUSPENSE,
+} from "@rx-state/core"
 
 /**
  * Binds an observable to React
@@ -21,7 +24,7 @@ import { StateObservable, DefaultedStateObservable } from "@rxstate/core"
  */
 export function bind<T>(
   observable: Observable<T>,
-): [() => Exclude<T, typeof SUSPENSE>, StateObservable<T>]
+): [() => Exclude<T, typeof SUSPENSE>, StateObservable<T, never>]
 
 /**
  * Binds an observable to React
@@ -38,7 +41,7 @@ export function bind<T>(
 export function bind<T>(
   observable: Observable<T>,
   defaultValue: T,
-): [() => Exclude<T, typeof SUSPENSE>, DefaultedStateObservable<T>]
+): [() => Exclude<T, typeof SUSPENSE>, DefaultedStateObservable<T, never>]
 
 /**
  * Binds a factory observable to React
@@ -62,7 +65,7 @@ export function bind<A extends unknown[], O>(
   getObservable: (...args: A) => Observable<O>,
 ): [
   (...args: A) => Exclude<O, typeof SUSPENSE>,
-  (...args: A) => StateObservable<O>,
+  (...args: A) => StateObservable<O, never>,
 ]
 
 /**
@@ -86,7 +89,7 @@ export function bind<A extends unknown[], O>(
   defaultValue: O | ((...args: A) => O),
 ): [
   (...args: A) => Exclude<O, typeof SUSPENSE>,
-  (...args: A) => DefaultedStateObservable<O>,
+  (...args: A) => DefaultedStateObservable<O, never>,
 ]
 
 export function bind(observable: any, defaultValue?: any) {

packages/core/src/bind/connectObservable.ts

@@ -1,6 +1,5 @@
-export * from "@rxstate/core"
+export * from "@rx-state/core"
 export { shareLatest } from "./shareLatest"
 export { useStateObservable } from "./useStateObservable"
 export { bind } from "./bind"
-export { SUSPENSE } from "./SUSPENSE"
 export { Subscribe, RemoveSubscribe } from "./Subscribe"