Scaffold multiple npm libs #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'origin' into scaffold-multiple-npm-libs
cpsievert
reviewed
Jan 25, 2019
| toDepJSON <- function(npmPkgs) { | ||
| if (is.null(npmPkgs)) { | ||
| "" | ||
| } else { |
Contributor
There was a problem hiding this comment.
I would add another check here to make sure names(npmPkgs) returns something sensible, like
else if (!length(names(npmPkgs))) {
stop("Must specify npm package names in the names attributes of npmPkgs")
} else {
paste0(sprintf('"%s": "%s"', names(npmPkgs), npmPkgs), collapse = ",\n")
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes improvements suggested by @cpsievert in #8; the
npmPkgargument is now callednpmPkgs, and the user may supply multiple npm dependencies as a named list mapping name to version.#11 should be merged to master first.