Skip to content

Conversation

@timelyportfolio
Copy link
Collaborator

Reverts #26

@timelyportfolio
Copy link
Collaborator Author

@alandipert for now I have reverted #26 since this will cause all our examples to break and likely solves an exception while breaking the norm.

@timelyportfolio timelyportfolio merged commit 9d856b1 into master Apr 27, 2019
@alandipert
Copy link
Collaborator

Thanks, makes sense, I'll dig into it this week.

@timelyportfolio
Copy link
Collaborator Author

@alandipert I looked into it a little bit and I think we could pursue a strategy where defaultOption is a function that returns false and then if a user wants different behavior they can provide through options similar to defaultReceiveMessage. I am happy to submit pull if you agree with the idea.

@timelyportfolio timelyportfolio deleted the revert-26-input-impl-getType branch September 14, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants