Skip to content

Commit 6453576

Browse files
committed
fixed lint errors and also removed shared config
1 parent 3880323 commit 6453576

File tree

7 files changed

+18
-22
lines changed

7 files changed

+18
-22
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
import test from 'ava'
2-
import { createConfig } from '../../dist';
1+
import test from 'ava';
2+
import {createConfig} from '../../dist';
33

4-
test("should set config and return it", t => {
4+
test('should set config and return it', t => {
55
const config = createConfig({
66
requestSuffixes: ['R', 'C', 'F']
77
});
88

99
t.deepEqual(config, {
10-
requestSuffixes: ['R', 'C','F']
10+
requestSuffixes: ['R', 'C', 'F']
1111
});
1212
});

src/__tests__/create-request-actions.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import test from 'ava';
22

3-
import {createRequestTypes, createRequestActions} from "../../dist";
3+
import {createRequestTypes, createRequestActions} from '../../dist';
44

5-
test("should return valid action creators for request types", t => {
5+
test('should return valid action creators for request types', t => {
66
const SIMPLE_ACTION_RT = createRequestTypes('SIMPLE_ACTION_RT');
77
const simpleActionRT = createRequestActions(SIMPLE_ACTION_RT);
88

src/__tests__/create-request-types.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import test from 'ava';
22

3-
import { createRequestTypes, createConfig, config } from '../../dist';
3+
import {createRequestTypes, createConfig} from '../../dist';
44

55
// Constants
66
const SIMPLE_ACTION_CONSTANT = 'SIMPLE_ACTION_CONSTANT';
@@ -20,7 +20,7 @@ test('createRequestTypes should return a list of types with request suffixes', t
2020
});
2121
});
2222

23-
test('createRequestTypes should return a list of types with request suffixes', t => {
23+
test('createRequestTypes should return a list of types with request suffixes#2', t => {
2424
createConfig({
2525
requestSuffixes: ['START', 'DONE', 'FAIL']
2626
});

src/create-config.js

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,19 @@
11
import defaultRTSuffixes from './request-type-suffixes';
2-
import requestTypeSuffixes from './request-type-suffixes';
32

4-
export let sharedConfig = {
5-
requestSuffixes: defaultRTSuffixes
6-
}
7-
8-
const createConfig = ({ requestSuffixes }) => {
3+
const createConfig = ({requestSuffixes = defaultRTSuffixes}) => {
4+
let config = {};
95
if (requestSuffixes) {
106
try {
11-
sharedConfig.requestSuffixes = requestSuffixes;
7+
config.requestSuffixes = requestSuffixes;
128
} catch (error) {
13-
console.warn('Request suffixes are already set somewhere in your code.')
9+
console.warn('Request suffixes are already set somewhere in your code.');
1410
}
1511

1612
// This prevents direct access and modification of shared config object
17-
sharedConfig = Object.freeze(sharedConfig)
13+
config = Object.freeze(config);
1814

19-
return sharedConfig;
15+
return config;
2016
}
21-
}
17+
};
2218

2319
export default createConfig;

src/create-request-actions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import createAction from './create-action';
22

3-
export default function(types) {
3+
export default function (types) {
44
const res = {};
55

66
Object.keys(types).forEach(type => {

src/create-request-types.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import {sharedConfig as config} from './create-config';
1+
import createConfig from './create-config';
22

33
function createRequestTypes(base) {
4+
const config = createConfig();
45
const res = {};
56
const suffixes = config.requestSuffixes;
67

src/request-type-suffixes.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ export const SuffixEnum = Object.freeze({
44
FAILED: 'FAILED'
55
});
66

7-
87
export default [
98
SuffixEnum.REQUESTED,
109
SuffixEnum.COMPLETED,

0 commit comments

Comments
 (0)