Use JDK 21 in workflows #2148
Open
Use JDK 21 in workflows #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also does some minor cleanup to workflows. Starting with AGP 9, building with Java 17 is no longer supported, Java 8 still works for compiling, but building will require Java 21 or later so this is preparing for that. It might still be out a bit but it's probably a good thing to start preparing for it and using it here in workflows, etc... would also help to encourage extension developers and other developers who contribute to the app to use it more for a more gradual migration to it, akin to when we deprecate something so it doesn't take developers by surprise for those that still use versions lower than Java 21 to build.
Contributor
Author
|
Just to note AGP 9 moved from alpha to beta recently, which means our timeline for this is moving up. Bumping AGP isn't something we just can't do either due to how Android Studio (unfortunately) works. I personally feel we should prepare for this ahead of time also to give extensions more time to adapt to it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with AGP 9, building with Java 17 is no longer supported, Java 8 still works for compiling, but building will require Java 21 or later so this is preparing for that. It might still be out a bit but it's probably a good thing to start preparing for it and using it here in workflows, etc... would also help to encourage extension developers and other developers who contribute to the app to use it more for a more gradual migration to it, akin to when we deprecate something so it doesn't take developers by surprise for those that still use versions lower than Java 21 to build.