Skip to content

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Oct 4, 2024

What type of PR is this?

/kind chore

What does this PR do / why we need it:

Update v1.14 to Argo Rollouts v0.0.4.1, to pick up argoproj-labs/argo-rollouts-manager#95

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2024

@jgwest: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind chore

What does this PR do / why we need it:

Update v1.14 to Argo Rollouts v0.0.4.1, to pick up argoproj-labs/argo-rollouts-manager#95

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from chetan-rns and sbose78 October 4, 2024 10:08
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest jgwest changed the title Update to v1.14 to Argo Rollouts v0.0.4.1 Update gitops-operator v1.14 to Argo Rollouts v0.0.4.1 Oct 4, 2024
@jgwest jgwest changed the title Update gitops-operator v1.14 to Argo Rollouts v0.0.4.1 Update gitops-operator v1.14 to Argo Rollouts operator v0.0.4.1 Oct 4, 2024
@jgwest jgwest force-pushed the update-rollouts-v1.14-oct-2024 branch from bd57527 to fa3f1b1 Compare October 4, 2024 10:36
@jparsai
Copy link
Collaborator

jparsai commented Oct 4, 2024

/lgtm

@jgwest
Copy link
Member Author

jgwest commented Oct 8, 2024

Thanks @jparsai!

@jgwest jgwest merged commit ce8ac80 into redhat-developer:v1.14 Oct 8, 2024
13 of 14 checks passed
ishitasequeira pushed a commit to ishitasequeira/gitops-operator that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants