-
-
Notifications
You must be signed in to change notification settings - Fork 136
Closed
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationhelp wantedExtra attention is neededExtra attention is needed
Description
The longest example in README.md contains this code:
const options = {
replace: ({ attribs, children }) => {
if (!attribs) return;
if (attribs.id === 'main') {
return (
<h1 style={{ fontSize: 42 }}>{domToReact(children, parserOptions)}</h1>
);
}
if (attribs.class === 'prettify') {
return (
<span style={{ color: 'hotpink' }}>
{domToReact(children, parserOptions)}
</span>
);
}
}
};
It's calling domToReact with parserOptions
(undefined in the example) as the second option. Shouldn't that be options
?
Thanks for a useful package!
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationhelp wantedExtra attention is neededExtra attention is needed
Activity
remarkablemark commentedon Oct 1, 2019
Yes, great catch @dbvisel! Would you like the honors of opening a pull request to fix this?
dbvisel commentedon Oct 1, 2019
Happy to do it!
docs(readme): change parserOptions to options in longest example
Merge pull request #123 from dbvisel/patch-1