Skip to content

Commit f8f0f01

Browse files
committed
Merge branch 'xonvanetta-master'
2 parents 680b4e2 + 3ae9db7 commit f8f0f01

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

pkg/sinks/slack.go

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package sinks
22

33
import (
44
"context"
5+
"sort"
56

67
"github.com/resmoio/kubernetes-event-exporter/pkg/kube"
78
"github.com/rs/zerolog/log"
@@ -58,20 +59,33 @@ func (s *SlackSink) Send(ctx context.Context, ev *kube.EnhancedEvent) error {
5859
})
5960
}
6061

62+
sort.SliceStable(fields, func(i, j int) bool {
63+
return fields[i].Title < fields[j].Title
64+
})
65+
6166
// make slack attachment
6267
slackAttachment := slack.Attachment{}
6368
slackAttachment.Fields = fields
6469
if s.cfg.AuthorName != "" {
65-
slackAttachment.AuthorName = s.cfg.AuthorName
70+
slackAttachment.AuthorName, err = GetString(ev, s.cfg.AuthorName)
71+
if err != nil {
72+
return err
73+
}
6674
}
6775
if s.cfg.Color != "" {
6876
slackAttachment.Color = s.cfg.Color
6977
}
7078
if s.cfg.Title != "" {
71-
slackAttachment.Title = s.cfg.Title
79+
slackAttachment.Title, err = GetString(ev, s.cfg.Title)
80+
if err != nil {
81+
return err
82+
}
7283
}
7384
if s.cfg.Footer != "" {
74-
slackAttachment.Footer = s.cfg.Footer
85+
slackAttachment.Footer, err = GetString(ev, s.cfg.Footer)
86+
if err != nil {
87+
return err
88+
}
7589
}
7690

7791
options = append(options, slack.MsgOptionAttachments(slackAttachment))

pkg/sinks/tmpl.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,16 @@ package sinks
33
import (
44
"bytes"
55
"encoding/json"
6-
"github.com/Masterminds/sprig/v3"
7-
"github.com/resmoio/kubernetes-event-exporter/pkg/kube"
86
"text/template"
7+
8+
"github.com/resmoio/kubernetes-event-exporter/pkg/kube"
9+
"github.com/Masterminds/sprig/v3"
910
)
1011

1112
func GetString(event *kube.EnhancedEvent, text string) (string, error) {
1213
tmpl, err := template.New("template").Funcs(sprig.TxtFuncMap()).Parse(text)
1314
if err != nil {
14-
return "", nil
15+
return "", err
1516
}
1617

1718
buf := new(bytes.Buffer)

0 commit comments

Comments
 (0)