Merge pull request #76 from richardschneider/codacy

chore: use codacy for QA

Author: richardschneider

.codacy.yml

@@ -0,0 +1,3 @@
+---
+exclude_paths:
+  - 'test/**/*'

IpfsCore.sln

@@ -8,6 +8,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "IpfsCoreTests", "test\IpfsC
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{DA715302-8746-4884-95F9-B56F069A0451}"
 	ProjectSection(SolutionItems) = preProject
+		.codacy.yml = .codacy.yml
 		.travis.yml = .travis.yml
 		appveyor.yml = appveyor.yml
 		builddocs.cmd = builddocs.cmd

README.md

@@ -2,6 +2,7 @@
 
 [![build status](https://ci.appveyor.com/api/projects/status/github/richardschneider/net-ipfs-core?branch=master&svg=true)](https://ci.appveyor.com/project/richardschneider/net-ipfs-core) 
 [![travis build](https://travis-ci.org/richardschneider/net-ipfs-core.svg?branch=master)](https://travis-ci.org/richardschneider/net-ipfs-core)
+[![Codacy Badge](https://api.codacy.com/project/badge/Grade/a911c5ae1f044e92bfc006bbc945e135)](https://www.codacy.com/app/makaretu/net-ipfs-core?utm_source=github.com&utm_medium=referral&utm_content=richardschneider/net-ipfs-core&utm_campaign=Badge_Grade)
 [![Coverage Status](https://coveralls.io/repos/richardschneider/net-ipfs-core/badge.svg?branch=master&service=github)](https://coveralls.io/github/richardschneider/net-ipfs-core?branch=master)
 [![Version](https://img.shields.io/nuget/v/Ipfs.Core.svg)](https://www.nuget.org/packages/Ipfs.Core)
 [![docs](https://cdn.rawgit.com/richardschneider/net-ipfs-core/master/doc/images/docs-latest-green.svg)](https://richardschneider.github.io/net-ipfs-core/articles/intro.html)
@@ -11,7 +12,6 @@ The core objects and interfaces of the [IPFS](https://github.com/ipfs/ipfs) (Int
 The interplanetary file system is the permanent web. It is a new hypermedia distribution protocol, addressed by content and identities. IPFS enables the creation of completely distributed applications. It aims to make the web faster, safer, and more open.
 
 It supports the following runtimes
-
 - .NET Framework 4.5
 - .NET Standard 1.4
 - .NET Standard 2.0
@@ -64,16 +64,16 @@ Most binary data (objects) in IPFS is represented as a [Base-58](https://en.wiki
 
 > Base58 is a group of binary-to-text encoding schemes used to represent large integers as alphanumeric text. It is similar to Base64 but has been modified to avoid both non-alphanumeric characters and letters which might look ambiguous when printed. It is therefore designed for human users who manually enter the data, copying from some visual source, but also allows easy copy and paste because a double-click will usually select the whole string. 
 
-# Related Projects
+## Related Projects
 
 - [IPFS DSL](https://github.com/cloveekprojeqt/ipfs-dsl) - A declarative embedded language for building compositional programs and protocols over the InterPlanetary File System.
 - [IPFS HTTP Client](https://github.com/richardschneider/net-ipfs-http-client) - A .Net client library for the IPFS HTTP API.
 - [IPFS Engine](https://github.com/richardschneider/net-ipfs-engine) - Implements the Core API.
 - [Peer Talk](https://github.com/richardschneider/peer-talk) - Peer to peer communication
 
-# License
-Copyright © 2015-2018 Richard Schneider ([email protected])
+## License
+Copyright © 2015-2019 Richard Schneider ([email protected])
 
-The IPFS Core library is licensed under the [MIT](http://www.opensource.org/licenses/mit-license.php "Read more about the MIT license form") license. Refere to the [LICENSE](https://github.com/richardschneider/net-ipfs-core/blob/master/LICENSE) file for more information.
+The IPFS Core library is licensed under the [MIT](http://www.opensource.org/licenses/mit-license.php "Read more about the MIT license form") license. Refer to the [LICENSE](https://github.com/richardschneider/net-ipfs-core/blob/master/LICENSE) file for more information.
 
 <a href="https://www.buymeacoffee.com/kmXOxKJ4E" target="_blank"><img src="https://www.buymeacoffee.com/assets/img/custom_images/yellow_img.png" alt="Buy Me A Coffee" style="height: auto !important;width: auto !important;" ></a>

src/Cid.cs

@@ -51,7 +51,9 @@ public class Cid : IEquatable<Cid>
         void EnsureMutable()
         {
             if (encodedValue != null)
+            {
                 throw new NotSupportedException("CID cannot be changed.");
+            }
         }
 
         /// <summary>
@@ -213,8 +215,9 @@ public override string ToString()
         public string Encode()
         {
             if (encodedValue != null)
+            {
                 return encodedValue;
-
+            }
             if (Version == 0)
             {
                 encodedValue = Hash.ToBase58();
@@ -421,7 +424,9 @@ public static Cid Read(byte[] buffer)
         public byte[] ToArray()
         {
             if (Version == 0)
+            {
                 return Hash.ToArray();
+            }
 
             using (var ms = new MemoryStream())
             {
@@ -487,10 +492,18 @@ public bool Equals(Cid that)
         /// </summary>
         public static bool operator ==(Cid a, Cid b)
         {
-            if (object.ReferenceEquals(a, b)) return true;
-            if (object.ReferenceEquals(a, null)) return false;
-            if (object.ReferenceEquals(b, null)) return false;
-
+            if (object.ReferenceEquals(a, b))
+            {
+                return true;
+            }
+            if (object.ReferenceEquals(a, null))
+            {
+                return false;
+            }
+            if (object.ReferenceEquals(b, null))
+            {
+                return false;
+            }
             return a.Equals(b);
         }
 
@@ -499,10 +512,18 @@ public bool Equals(Cid that)
         /// </summary>
         public static bool operator !=(Cid a, Cid b)
         {
-            if (object.ReferenceEquals(a, b)) return false;
-            if (object.ReferenceEquals(a, null)) return true;
-            if (object.ReferenceEquals(b, null)) return true;
-
+            if (object.ReferenceEquals(a, b))
+            {
+                return false;
+            }
+            if (object.ReferenceEquals(a, null))
+            {
+                return true;
+            }
+            if (object.ReferenceEquals(b, null))
+            {
+                return true;
+            }
             return !a.Equals(b);
         }
 

src/MultiAddress.cs

@@ -306,7 +306,9 @@ void Read(CodedInputStream stream)
         void Read(TextReader stream)
         {
             if (stream.Read() != '/')
+            {
                 throw new FormatException("An IFPS multiaddr must start with '/'.");
+            }
 
             var name = new StringBuilder();
             Protocols.Clear();

src/MultiHash.cs

@@ -107,7 +107,9 @@ public MultiHash(string algorithmName, byte[] digest)
                 throw new ArgumentNullException("digest");
 
             if (!HashingAlgorithm.Names.TryGetValue(algorithmName, out HashingAlgorithm a))
+            {
                 throw new ArgumentException(string.Format("The IPFS hashing algorithm '{0}' is unknown.", algorithmName));
+            }
             Algorithm = a;
 
             if (Algorithm.DigestSize != 0 && Algorithm.DigestSize != digest.Length)