WL#9306: X Protocol connectivity through unix sockets

Follow up fix: mysqlxtest is missing description of "-v" command line
option also connection_require_secure_transport.test uses wrong option when running mysqlxtest.

Reviewed-by: Andrzej Religa <[email protected]>

Author: lkotula

rapid/plugin/x/mysqlxtest_src/mysqlxtest.cc

@@ -111,6 +111,9 @@ static void ignore_traces_from_libraries(enum loglevel ll, const char *format, v
 
 static void replace_all(std::string &input, const std::string &to_find, const std::string &change_to)
 {
+  if (to_find.empty())
+    return;
+
   size_t position = input.find(to_find);
 
   while (std::string::npos != position)
@@ -2758,6 +2761,7 @@ class My_command_line_options : public Command_line_options
     std::cout << "--tls-version         TLS version to use\n";
     std::cout << "--connect-expired-password Allow expired password\n";
     std::cout << "--quiet               Don't print out messages sent\n";
+    std::cout << "-vVARIABLE_NAME=VALUE Set variable VARIABLE_NAME from command line\n";
     std::cout << "--fatal-errors=<0|1>  Mysqlxtest is started with ignoring or stopping on fatal error\n";
     std::cout << "-B, --bindump         Dump binary representation of messages sent, in format suitable for\n";
     std::cout << "--verbose             Enable extra verbose messages\n";

rapid/plugin/x/tests/mtr/r/connection_require_secure_transport.result

@@ -3,6 +3,9 @@ call mtr.add_suppression("Plugin mysqlx reported: .Failed at SSL configuration:
 call mtr.add_suppression("Plugin mysqlx reported: .SSL_CTX_load_verify_locations failed.");
 call mtr.add_suppression("Plugin mysqlx reported: ....: Unsuccessful login attempt: Secure transport required. To log in you must use TCP.SSL or UNIX socket connection");
 Wait for the X Plugin before restarting the server
+Mysqlx.Ok {
+  msg: "bye!"
+}
 ok
 Test different connection types while secure transport when the server was started with this flag set to ON
 # restart: --require_secure_transport=ON

rapid/plugin/x/tests/mtr/t/connection_require_secure_transport.test

@@ -43,7 +43,7 @@ EOF
 call mtr.add_suppression("Plugin mysqlx reported: ....: Unsuccessful login attempt: Secure transport required. To log in you must use TCP.SSL or UNIX socket connection");
 
 --echo Wait for the X Plugin before restarting the server
---exec $MYSQLXTEST -n  -uroot --password='' --file=$MYSQL_TMP_DIR/check_connection.tmp 2>&1
+--exec $MYSQLXTEST -q -uroot --password='' --file=$MYSQL_TMP_DIR/check_connection.tmp 2>&1
 
 --echo Test different connection types while secure transport when the server was started with this flag set to ON
 # Cases when the flag is dynamicly changes is tests in related x test file (for example connection_ssl.test)