env var err should be returned

mordyovits · mordyovits · commit dfed24ece763 · 2014-12-01T11:29:03.000-05:00
Currently, if the computeVar() call rturns an err it's lost.  The actual 'return value, err' line cannot return an error ever, because the err value is tested above the computeVar() call in line 150 and would have returned already.  With this patch the env var computeVar() err is returned correctly.
diff --git a/type.go b/type.go
@@ -152,7 +152,7 @@ func (c *Config) String(section string, option string) (value string, err error)
 	}
 
 	// $ environment variables
-	computedVal, _ = c.computeVar(&value, envVarRegExp, 2, 1, func(varName *string) string {
+	computedVal, err = c.computeVar(&value, envVarRegExp, 2, 1, func(varName *string) string {
 		return os.Getenv(*varName)
 	})
 	value = *computedVal

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ func (c *Config) String(section string, option string) (value string, err error)`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`// $ environment variables`
`155`		`- computedVal, _ = c.computeVar(&value, envVarRegExp, 2, 1, func(varName *string) string {`
	`155`	`+ computedVal, err = c.computeVar(&value, envVarRegExp, 2, 1, func(varName *string) string {`
`156`	`156`	`return os.Getenv(*varName)`
`157`	`157`	`})`
`158`	`158`	`value = *computedVal`