Bug #29820184 REDO LOGS MAY SILENTLY BE IGNORED WHEN ENCRYPTED TABLE CANNOT BE DECRYPTED.

Problem:

There is a difference in behavior between debug and release server when redo
logs are to be applied to a table that cannot be decrypted. Debug server will
abort the start and release will generate errors but will start up. This is
because in log0recv.cc there is:

    if (space.first != TRX_SYS_SPACE &&
        !fil_tablespace_open_for_recovery(space.first)) {
      /* Tablespace was dropped. It should not have been scanned unless it
      is an undo space that was under construction. */
      ut_ad(!fil_tablespace_lookup_for_recovery(space.first) ||
            fsp_is_undo_tablespace(space.first));

      dropped = true;

the call to fil_tablespace_lookup_for_recover will add space id to missing_ids
which in turn will trigger this from srv0start.cc:

    if (srv_force_recovery == 0 && fil_check_missing_tablespaces()) {
      ib::error(ER_IB_MSG_1139);

      /* Set the abort flag to true. */
      auto p = recv_recovery_from_checkpoint_finish(*log_sys, true);

      ut_a(p == nullptr);

      return (srv_init_abort(DB_ERROR));
    }

fil_check_missing_tablespaces will return true.

For release the fil_tablespace_lookup_for_recover will not be called as it is
inside a debug assert. The release version should be fixed and abort to start.

Solution:

Ensure that fil_tablespace_lookup_for_recover() is called for release build also.

rb#22564 approved by Mayank Prasad <[email protected]>

Author: gurusami

mysql-test/suite/innodb/r/missing_redologs.result

@@ -0,0 +1,40 @@
+CREATE TABLE t1(
+a INT NOT NULL PRIMARY KEY,
+c CHAR(200),
+b BLOB,
+INDEX(b(10))) ENGINE=innodb ROW_FORMAT=compressed ENCRYPTION='Y';
+CREATE TABLE t2(
+a INT NOT NULL PRIMARY KEY,
+c CHAR(200),
+b BLOB,
+INDEX(b(10))) ENGINE=innodb ROW_FORMAT=compressed ENCRYPTION='Y';
+CREATE TABLE t3(
+a INT NOT NULL PRIMARY KEY,
+c CHAR(200),
+b BLOB,
+INDEX(b(10))) ENGINE=innodb ENCRYPTION='Y';
+CREATE TABLE t4(
+a INT NOT NULL PRIMARY KEY,
+c CHAR(200),
+b BLOB,
+INDEX(b(10))) ENGINE=innodb ENCRYPTION='Y';
+# restart
+INSERT INTO t2 SELECT * FROM t1;
+INSERT INTO t3 SELECT * FROM t1;
+INSERT INTO t4 SELECT * FROM t1;
+COMMIT;
+SET GLOBAL innodb_flush_log_at_trx_commit=1;
+BEGIN;
+UPDATE t1 SET c = REPEAT('secret3', 20);
+UPDATE t2 SET c = REPEAT('secret4', 20);
+UPDATE t3 set c = REPEAT('secret4', 20);
+UPDATE t4 set c = REPEAT('secret4', 20);
+INSERT INTO t1 (a,c,b) VALUES (21, REPEAT('secret5',20), REPEAT('secret6',6000));
+INSERT INTO t2 (a,c,b) VALUES (21, REPEAT('secret7',20), REPEAT('secret8',6000));
+INSERT into t3 (a,c,b) VALUES (21, REPEAT('secret9',20), REPEAT('secre10',6000));
+INSERT into t4 (a,c,b) VALUES (21, REPEAT('secre11',20), REPEAT('secre12',6000));
+COMMIT;
+# Kill the server
+# Restart mysqld without keyring plugin
+# Restart mysqld with keyring plugin
+drop TABLE t1,t2,t3,t4;

mysql-test/suite/innodb/t/missing_redologs-master.opt

@@ -0,0 +1,3 @@
+$KEYRING_PLUGIN_OPT
+--early-plugin-load="keyring_file=$KEYRING_PLUGIN"
+--loose-keyring_file_data=$MYSQLTEST_VARDIR/std_data/keys2.txt

mysql-test/suite/innodb/t/missing_redologs.test

@@ -0,0 +1,73 @@
+CREATE TABLE t1(
+  a INT NOT NULL PRIMARY KEY,
+  c CHAR(200),
+  b BLOB,
+  INDEX(b(10))) ENGINE=innodb ROW_FORMAT=compressed ENCRYPTION='Y';
+
+CREATE TABLE t2(
+  a INT NOT NULL PRIMARY KEY,
+  c CHAR(200),
+  b BLOB,
+  INDEX(b(10))) ENGINE=innodb ROW_FORMAT=compressed ENCRYPTION='Y';
+
+CREATE TABLE t3(
+  a INT NOT NULL PRIMARY KEY,
+  c CHAR(200),
+  b BLOB,
+  INDEX(b(10))) ENGINE=innodb ENCRYPTION='Y';
+
+CREATE TABLE t4(
+  a INT NOT NULL PRIMARY KEY,
+  c CHAR(200),
+  b BLOB,
+  INDEX(b(10))) ENGINE=innodb ENCRYPTION='Y';
+
+--source include/restart_mysqld.inc
+
+--source include/no_checkpoint_start.inc
+
+--disable_query_log
+--let $i = 20
+BEGIN;
+WHILE ($i)
+{
+  eval INSERT INTO t1(a,c,b) VALUES ($i, REPEAT('secret1',20), REPEAT('secret2',6000));
+  dec $i;
+}
+--enable_query_log
+
+INSERT INTO t2 SELECT * FROM t1;
+INSERT INTO t3 SELECT * FROM t1;
+INSERT INTO t4 SELECT * FROM t1;
+COMMIT;
+
+# If checkpoint happens we will skip this test.
+# If no checkpoint  happens, InnoDB refuses to
+# start as used  encryption key is not found.
+
+SET GLOBAL innodb_flush_log_at_trx_commit=1;
+BEGIN;
+UPDATE t1 SET c = REPEAT('secret3', 20);
+UPDATE t2 SET c = REPEAT('secret4', 20);
+UPDATE t3 set c = REPEAT('secret4', 20);
+UPDATE t4 set c = REPEAT('secret4', 20);
+INSERT INTO t1 (a,c,b) VALUES (21, REPEAT('secret5',20), REPEAT('secret6',6000));
+INSERT INTO t2 (a,c,b) VALUES (21, REPEAT('secret7',20), REPEAT('secret8',6000));
+INSERT into t3 (a,c,b) VALUES (21, REPEAT('secret9',20), REPEAT('secre10',6000));
+INSERT into t4 (a,c,b) VALUES (21, REPEAT('secre11',20), REPEAT('secre12',6000));
+COMMIT;
+
+let $cleanup= drop TABLE t1,t2,t3,t4;
+--let CLEANUP_IF_CHECKPOINT= $cleanup;
+--source include/no_checkpoint_end.inc
+
+--echo # Restart mysqld without keyring plugin
+
+--error 1
+--exec $MYSQLD_CMD
+
+--echo # Restart mysqld with keyring plugin
+--let $restart_parameters=restart:--early-plugin-load="keyring_file=$KEYRING_PLUGIN" --keyring-file-data=$MYSQLTEST_VARDIR/std_data/keys2.txt
+--source include/start_mysqld_no_echo.inc
+
+drop TABLE t1,t2,t3,t4;

storage/innobase/log/log0recv.cc

@@ -1267,8 +1267,10 @@ void recv_apply_hashed_log_recs(log_t &log, bool allow_ibuf) {
         !fil_tablespace_open_for_recovery(space.first)) {
       /* Tablespace was dropped. It should not have been scanned unless it
       is an undo space that was under construction. */
-      ut_ad(!fil_tablespace_lookup_for_recovery(space.first) ||
-            fsp_is_undo_tablespace(space.first));
+
+      if (fil_tablespace_lookup_for_recovery(space.first)) {
+        ut_ad(fsp_is_undo_tablespace(space.first));
+      }
 
       dropped = true;
     } else {