feat: add option to ignore minification of specific elements in CollapseWhitespace middleware

dotninth · dotninth · commit b8cacf52332d · 2023-08-11T22:59:40.000+03:00
diff --git a/README.md b/README.md
@@ -92,6 +92,7 @@ protected $middleware = [
 - `RemoveComments::class`: Removes HTML, JS, and CSS comments from the output to reduce the transfer size of HTML files.
 - `CollapseWhitespace::class`: Reduces the size of HTML files by removing unnecessary white space.
   - **It automatically calls the `RemoveComments::class` middleware before executing.**
+  - You can **ignore** minification of some elements. Add `data-tachyon-ignore` as an element attribute to do so.
 - `RemoveQuotes::class`: Removes unnecessary quotes from HTML attributes, resulting in a reduced byte count on most pages.
 - `ElideAttributes::class`: Reduces the transfer size of HTML files by removing attributes from tags if their values match the default attribute values.
 - `InsertDNSPrefetch::class`: Includes `<link rel="dns-prefetch" href="//www.example.com">` tags in the HTML `<head>` section to enable DNS prefetching, reducing DNS lookup time and improving page load times.
diff --git a/src/Middleware/CollapseWhitespace.php b/src/Middleware/CollapseWhitespace.php
@@ -85,7 +85,7 @@ protected function hideElements(string $buffer): string
     protected function findSkippedElements(string $buffer): void
     {
         foreach ($this->ignoreElements as $element) {
-            $pattern = '/<' . $element . '[^>]*>(.*)<\/' . $element . '>/Uuis';
+            $pattern = '/<' . $element . '[^>]*data-tachyon-ignore[^>]*|<' . $element . '[^>]*>(.*)<\/' . $element . '>/Uuis';
             if (preg_match_all($pattern, $buffer, $matches, PREG_SET_ORDER)) {
                 foreach ($matches as $match) {
                     $this->addSkippedElement($match[1]);

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ protected function hideElements(string $buffer): string`
`85`	`85`	`protected function findSkippedElements(string $buffer): void`
`86`	`86`	`{`
`87`	`87`	`foreach ($this->ignoreElements as $element) {`
`88`		`- $pattern = '/<' . $element . '[^>]>(.)<\/' . $element . '>/Uuis';`
	`88`	`+ $pattern = '/<' . $element . '[^>]data-tachyon-ignore[^>]\|<' . $element . '[^>]>(.)<\/' . $element . '>/Uuis';`
`89`	`89`	`if (preg_match_all($pattern, $buffer, $matches, PREG_SET_ORDER)) {`
`90`	`90`	`foreach ($matches as $match) {`
`91`	`91`	`$this->addSkippedElement($match[1]);`