Skip to content

Commit 9d0b7d8

Browse files
mhorowitzfacebook-github-bot
authored andcommitted
Fix BUCK bugs which were breaking tests after refactoring
Reviewed By: johnislarry Differential Revision: D7874275 fbshipit-source-id: 7f9c8648571bc7f41649ec4ef547e7c34b479221
1 parent a810e68 commit 9d0b7d8

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ReactCommon/cxxreact/BUCK

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ rn_xplat_cxx_library(
141141
],
142142
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
143143
fbobjc_deps = APPLE_JSC_DEPS,
144+
fbobjc_force_static = True,
144145
fbobjc_frameworks = [
145146
"$SDKROOT/System/Library/Frameworks/JavaScriptCore.framework",
146147
],

ReactCommon/cxxreact/tests/BUCK

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target")
1+
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "APPLE_JSC_DEPS", "ANDROID_JSC_DEPS")
22

33
TEST_SRCS = [
44
"RecoverableErrorTest.cpp",
@@ -28,7 +28,7 @@ if not IS_OSS_BUILD:
2828
'xplat//third-party/linker_lib:android',
2929
'xplat//third-party/gmock:gtest',
3030
react_native_xplat_target('cxxreact:bridge'),
31-
],
31+
] + ANDROID_JSC_DEPS,
3232
visibility = [
3333
'fbandroid//instrumentation_tests/...'
3434
],
@@ -47,7 +47,7 @@ if not IS_OSS_BUILD:
4747
'xplat//third-party/gmock:gtest',
4848
react_native_xplat_target('cxxreact:bridge'),
4949
react_native_xplat_target('jschelpers:jschelpers'),
50-
],
50+
] + APPLE_JSC_DEPS,
5151
visibility = [
5252
react_native_xplat_target('cxxreact/...'),
5353
],

0 commit comments

Comments
 (0)