update README further + remove unneeded header setter

Author: kbsali

README.markdown

@@ -30,7 +30,6 @@ Uses [Redmine API](http://www.redmine.org/projects/redmine/wiki/Rest_api/).
 
 ## Todo
 
-* API entry points :
 * Check header's response code (especially for POST/PUT/DELETE requests)
  * See http://stackoverflow.com/questions/9183178/php-curl-retrieving-response-headers-and-body-in-a-single-request/9183272#9183272
 * Maybe Guzzle for handling http connections
@@ -108,6 +107,7 @@ $client->setImpersonateUser(null);
 
 ### Thanks!
 
-- Thanks to [Thomas Spycher](https://github.com/tspycher/) for the 1st version of the class.
-- Thanks to [Thibault Duplessis aka. ornicar](https://github.com/ornicar) for the php-github-api library, great source of inspiration!
-- And all the [contributors](https://github.com/kbsali/php-redmine-api/graphs/contributors) and specially [JanMalte](https://github.com/JanMalte) for his impressive contribution to the test coverage! :)
+* Thanks to [Thomas Spycher](https://github.com/tspycher/) for the 1st version of the class.
+* Thanks to [Thibault Duplessis aka. ornicar](https://github.com/ornicar) for the php-github-api library, great source of inspiration!
+* And all the [contributors](https://github.com/kbsali/php-redmine-api/graphs/contributors)
+ * specially [JanMalte](https://github.com/JanMalte) for his impressive contribution to the test coverage! :)

example.php

@@ -4,12 +4,11 @@
  * @file
  * This file holds example commands for reading, creating, updating and deleting redmine components.
  */
- 
+
 // As this is only an example file, we make sure, this is not accidently executed and may destroy real
 // life content.
 return;
 
-
 require_once 'vendor/autoload.php';
 
 // ----------------------------

lib/Redmine/Client.php

@@ -34,11 +34,6 @@ class Client
      */
     private $apikeyOrUsername;
 
-    /**
-     * @var string
-     */
-    private $apikeyHeaderName = 'X-Redmine-API-Key';
-
     /**
      * @var string or null
      */
@@ -263,29 +258,6 @@ public function setPort($port = null)
         return $this;
     }
 
-    /**
-     * Set the name of the HTTP header used to set the API key for authentication
-     * @param  string $name
-     * @return Client
-     */
-    public function setApikeyHeaderName($name = null)
-    {
-        if (null !== $name) {
-            $this->apikeyHeaderName = $name;
-        }
-
-        return $this;
-    }
-
-    /**
-     * Returns the name of the HTTP header used to set the API key for authentication
-     * @return string
-     */
-    public function getApikeyHeaderName()
-    {
-        return $this->apikeyHeaderName;
-    }
-
     /**
      * Returns Redmine response code
      * @return int
@@ -380,13 +352,14 @@ protected function runRequest($path, $method = 'GET', $data = '')
             $httpHeader[] = 'Content-Type: application/json';
         }
 
+        // Redmine specific headers
         if ($this->impersonateUser) {
             $httpHeader[] = 'X-Redmine-Switch-User: ' . $this->impersonateUser;
         }
 
         if (!empty($httpHeader)) {
             if (null === $this->pass) {
-                $httpHeader[] = $this->apikeyHeaderName.': '.$this->apikeyOrUsername;
+                $httpHeader[] = 'X-Redmine-API-Key: '.$this->apikeyOrUsername;
             }
             curl_setopt($curl, CURLOPT_HTTPHEADER, $httpHeader);
         }

test/Redmine/Tests/ClientTest.php

@@ -107,28 +107,6 @@ public function testGetResponseCodeIsInitialNull()
         $this->assertEquals(0, $client->getResponseCode());
     }
 
-    /**
-     * @covers Redmine\Client
-     * @test
-     */
-    public function testGetApikeyHeaderNameReturnsSetApikeyHeaderName()
-    {
-        // Test values
-        $headerName = 'X-Header-Redmine-API-Auth';
-        $otherHeaderName = 'X-Header-API-Auth';
-
-        $client = new Client('http://test.local', 'asdf');
-
-        $this->assertSame($client, $client->setApikeyHeaderName($headerName));
-        $this->assertSame($headerName, $client->getApikeyHeaderName());
-
-        $this->assertSame($client, $client->setApikeyHeaderName(null));
-        $this->assertSame($headerName, $client->getApikeyHeaderName());
-
-        $this->assertSame($client, $client->setApikeyHeaderName($otherHeaderName));
-        $this->assertSame($otherHeaderName, $client->getApikeyHeaderName());
-    }
-
     /**
      * @covers Redmine\Client
      * @test