basic/fileio: fix memleak when discarding an invalid variable

keszybz · keszybz · commit 2ea8081a5543 · 2017-02-21T11:15:50.000-05:00
Fixes systemd#5405.
diff --git a/src/basic/fileio.c b/src/basic/fileio.c
@@ -780,6 +780,7 @@ static int merge_env_file_push(
 
         if (!env_name_is_valid(key)) {
                 log_error("%s:%u: invalid variable name \"%s\", ignoring.", strna(filename), line, key);
+                free(value);
                 return 0;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -780,6 +780,7 @@ static int merge_env_file_push(`
`780`	`780`
`781`	`781`	`if (!env_name_is_valid(key)) {`
`782`	`782`	`log_error("%s:%u: invalid variable name \"%s\", ignoring.", strna(filename), line, key);`
	`783`	`+ free(value);`
`783`	`784`	`return 0;`
`784`	`785`	`}`
`785`	`786`