Skip to content

Commit 29d6113

Browse files
committed
Use double click in Lists
instead of clicking selected items.
1 parent 8382547 commit 29d6113

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

dev/src/controls/List.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export default class List extends EventDispatcher {
5050
item.dataset.id = id;
5151
item.item = o;
5252
item.addEventListener("click", f);
53+
item.addEventListener("dblclick", f);
5354
}
5455
}
5556

@@ -87,9 +88,12 @@ export default class List extends EventDispatcher {
8788

8889
handleClick(evt) {
8990
let id = evt.currentTarget.dataset.id, old = this.selected;
90-
if (this.multi) {
91+
if (evt.type === "dblclick") {
92+
if (id != null) { this.dispatchEvent("dblclick"); }
93+
return;
94+
} else if (this.multi) {
9195
$.toggleClass(evt.currentTarget, "selected");
92-
} else if (this.selected === id) {
96+
} else if (old === id) {
9397
if (id != null) { this.dispatchEvent("selclick"); }
9498
return;
9599
} else {

dev/src/views/Sidebar.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export default class Sidebar {
146146
this.listEl = $.query("> .list", this.fullEl);
147147
this.menuList = new List(this.listEl, {data:content.kids, template:this.menuListTemplate});
148148
this.menuList.on("change", ()=> this.show(this.menuList.selectedItem));
149-
this.menuList.on("selclick", ()=> this._onSelClick(this.menuList.selectedItem));
149+
this.menuList.on("dblclick", ()=> this._onDblClick(this.menuList.selectedItem));
150150
this.contentEl = $.query("> .content", this.fullEl);
151151

152152
// set up minimized sidebar:
@@ -202,7 +202,7 @@ export default class Sidebar {
202202
return false;
203203
}
204204

205-
_onSelClick(o) {
205+
_onDblClick(o) {
206206
if (o.token) {
207207
let expr = app.expression;
208208
if (o.parent.id === "flags") { expr.toggleFlag(o.token); }

0 commit comments

Comments
 (0)