Skip to content

Commit 0c14852

Browse files
committed
refactoring
1 parent 4eea83d commit 0c14852

File tree

3 files changed

+27
-18
lines changed

3 files changed

+27
-18
lines changed

src/main/java/TestCodePropertyAnalyzer.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,9 @@ public class TestCodePropertyAnalyzer {
3939
private static int NumTests;
4040
private static int NumAsyncTests;
4141
private static int NumAssertions;
42-
private static int MaxFunCall;
43-
private static float AveFunCall;
42+
private static int NumFunCall = 0;
43+
private static int MaxFunCall = 0;
44+
private static float AveFunCall = 0;
4445
private static int NumDOMFixture;
4546
private static int NumTriggerTest;
4647
private static int NumObjCreate;
@@ -116,8 +117,10 @@ private static void analyseJSTestFile(String canonicalPath) throws Exception {
116117
NumTests += codeAnalyzer.getNumTests();
117118
NumAsyncTests += codeAnalyzer.getNumAsyncTests();
118119
NumAssertions += codeAnalyzer.getNumAssertions();
119-
MaxFunCall += codeAnalyzer.getMaxFunCall();
120-
AveFunCall += codeAnalyzer.getAveFunCall();
120+
NumFunCall += codeAnalyzer.getNumFunCall();
121+
if (codeAnalyzer.getNumFunCall() > MaxFunCall)
122+
MaxFunCall = codeAnalyzer.getNumFunCall();
123+
AveFunCall = (float)NumFunCall/(float)NumTests;
121124
NumDOMFixture += codeAnalyzer.getNumDOMFixture();
122125
NumTriggerTest += codeAnalyzer.getNumTriggerTest();
123126
NumObjCreate += codeAnalyzer.getNumObjCreate();

src/main/java/core/JSAnalyzer.java

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ public class JSAnalyzer {
2626
private static int NumTests = 0;
2727
private static int NumAsyncTests = 0;
2828
private static int NumAssertions = 0;
29-
private static int MaxFunCall = 0;
30-
private static float AveFunCall = 0;
29+
private static int NumFunCall = 0;
3130
private static int NumDOMFixture = 0;
3231
private static int NumTriggerTest = 0;
3332
private static int NumObjCreate = 0;
@@ -527,16 +526,15 @@ public void analyzeTestCodeProperties() throws Exception {
527526
NumTests = astVisitor.getTestCounter();
528527
NumAsyncTests = astVisitor.getAsynchTestCounter();
529528
NumAssertions = astVisitor.getAssertionCounter();
530-
//MaxFunCall = astVisitor.getMaxFunCall();
531-
//AveFunCall = astVisitor.getAveFunCall();
532-
//NumDOMFixture = astVisitor.getNumDOMFixture();
529+
NumFunCall = astVisitor.getFunCallCounter();
533530
NumTriggerTest = astVisitor.getTriggerCounetr();
534531
NumObjCreate = astVisitor.getNewExpressionCounter();
535532

536-
System.out.println("assertionCounter: " + astVisitor.getAssertionCounter());
537-
System.out.println("newExpressionCounter: " + astVisitor.getNewExpressionCounter());
538533
System.out.println("testCounter: " + astVisitor.getTestCounter());
539534
System.out.println("asynchTestCounter: " + astVisitor.getAsynchTestCounter());
535+
System.out.println("assertionCounter: " + astVisitor.getAssertionCounter());
536+
System.out.println("funCallCounter: " + astVisitor.getFunCallCounter());
537+
System.out.println("newExpressionCounter: " + astVisitor.getNewExpressionCounter());
540538
System.out.println("trieggerCounter: " + astVisitor.getTriggerCounetr());
541539

542540
/* clean up */
@@ -563,12 +561,8 @@ public int getNumAssertions() {
563561
return NumAssertions;
564562
}
565563

566-
public int getMaxFunCall() {
567-
return MaxFunCall;
568-
}
569-
570-
public float getAveFunCall() {
571-
return AveFunCall;
564+
public int getNumFunCall() {
565+
return NumFunCall;
572566
}
573567

574568
public int getNumDOMFixture() {

src/main/java/instrumentor/JSASTInstrumentor.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ public class JSASTInstrumentor implements NodeVisitor{
3939
private int testCounter = 0;
4040
private int asyncTestCounter = 0;
4141
private int assertionCounter = 0;
42+
private int funCallCounter = 0;
4243
private int newExpressionCounter = 0;
4344
private int triggerCounetr = 0;
4445

@@ -656,14 +657,16 @@ private void analyzeTestCodeFunctionCallNode(AstNode node) {
656657
TestCaseInfo t = testCaseInfoList.get(testCaseInfoList.size()-1);
657658
t.setNumFunCall(t.getNumFunCall()+1);
658659
System.out.println("Test case " + t.getTestNumber() + " has " + t.getNumFunCall() + " function calls!");
660+
funCallCounter++;
659661
}else{
660662
TestUtilityFunctionInfo tufi = testUtilityFunctionInfoList.get(testUtilityFunctionInfoList.size()-1);
661663
tufi.setNumFunCall(tufi.getNumFunCall()+1);
662664
System.out.println("Test utility function " + tufi.getFuncName() + " has " + tufi.getNumFunCall() + " function calls!");
663665
//System.out.println("A function call found out of a test case");
664666
}
667+
}else{
668+
System.out.println("Repeated!");
665669
}
666-
667670
}
668671

669672
}
@@ -1064,5 +1067,14 @@ public ArrayList<TestUtilityFunctionInfo> getTestUtilityFunctions() {
10641067
}
10651068

10661069

1070+
1071+
1072+
public void setFunCallCounter(int funCallCounter) {
1073+
this.funCallCounter = funCallCounter;
1074+
}
1075+
public int getFunCallCounter() {
1076+
return funCallCounter;
1077+
}
1078+
10671079
}
10681080

0 commit comments

Comments
 (0)