Ignore unknown falgs for init and create commands

If the user attempts to run a command like:

    riff create java --handler functions.Uppercase

...but they do not have the java invoker installed, they currently
recieve an unhelpful error saying the `--handler` flag is unknown. Since
the init and create root comamnds require an invoker, and some invokers
require the handler flag while others do no, we can relax the
enforcement of unknown flags for these commands. Subcommands continue to
enforce unknown flags.

The ability to supress unknown flag warnings is new in pflags v1.0.1.

Fixes projectriff#555

Author: scothis

riff-cli/cmd/create.go

@@ -29,6 +29,8 @@ func Create(initCmd *cobra.Command, buildCmd *cobra.Command, applyCmd *cobra.Com
 	createChainCmd.Use = "create"
 	createChainCmd.Short = "Create a function (equivalent to init, build, apply)"
 	createChainCmd.Long = utils.CreateCmdLong()
+
+	createChainCmd.Flags().ParseErrorsWhitelist.UnknownFlags = true
 	createChainCmd.SetUsageTemplate(utils.CustomInvokerUsageTemplate)
 
 	// ignore all validation

riff-cli/cmd/create_test.go

@@ -104,6 +104,23 @@ var _ = Describe("The create command", func() {
 			Expect(".").NotTo(HaveUnstagedChanges())
 		})
 
+		It("ignores unknown flags", func() {
+			os.Chdir("../test_data/riff-init/no-invokers")
+
+			invokers, err := stubInvokers("invokers/*.yaml")
+			Expect(err).NotTo(HaveOccurred())
+			rootCommand, _, _, _, err := setupCreateTest(invokers, normalDocker, dryRunDocker, normalKubeCtl, dryRunKubeCtl)
+			Expect(err).NotTo(HaveOccurred())
+
+			rootCommand.SetArgs(append([]string{"create", "java", "--handler", "functions.FooFunc"}, commonRiffArgs...))
+
+			err = rootCommand.Execute()
+			Expect(err).To(HaveOccurred())
+			Expect(err).To(Equal(fmt.Errorf("Invokers must be installed, run `riff invokers apply --help` for help")))
+
+			Expect(".").NotTo(HaveUnstagedChanges())
+		})
+
 		It("creates a function with a matched invoker", func() {
 			os.Chdir("../test_data/riff-init/matching-invoker")
 

riff-cli/cmd/init.go

@@ -68,6 +68,7 @@ func Init(invokers []projectriff_v1.Invoker) (*cobra.Command, *options.InitOptio
 	initCmd.PersistentFlags().StringVarP(&initOptions.Output, "output", "o", "", "the name of the output topic (optional)")
 	initCmd.PersistentFlags().BoolVar(&initOptions.Force, "force", utils.DefaultValues.Force, "overwrite existing functions artifacts")
 
+	initCmd.Flags().ParseErrorsWhitelist.UnknownFlags = true
 	initCmd.SetUsageTemplate(utils.CustomInvokerUsageTemplate)
 
 	return initCmd, &initOptions

riff-cli/cmd/init_test.go

@@ -72,6 +72,23 @@ var _ = Describe("The init command", func() {
 			Expect(".").NotTo(HaveUnstagedChanges())
 		})
 
+		It("ignores unknown flags", func() {
+			os.Chdir("../test_data/riff-init/no-invokers")
+
+			invokers, err := stubInvokers("invokers/*.yaml")
+			Expect(err).NotTo(HaveOccurred())
+			rootCommand, _, _, _, err := setupInitTest(invokers)
+			Expect(err).NotTo(HaveOccurred())
+
+			rootCommand.SetArgs(append([]string{"init", "--handler", "functions.FooFunc"}, commonRiffArgs...))
+
+			err = rootCommand.Execute()
+			Expect(err).To(HaveOccurred())
+			Expect(err).To(Equal(fmt.Errorf("Invokers must be installed, run `riff invokers apply --help` for help")))
+
+			Expect(".").NotTo(HaveUnstagedChanges())
+		})
+
 	})
 
 	Context("with an explict invoker", func() {
@@ -88,6 +105,24 @@ var _ = Describe("The init command", func() {
 
 			err = rootCommand.Execute()
 			Expect(err).To(HaveOccurred())
+			Expect(err).To(Equal(fmt.Errorf("The invoker must be specified. Pick one of: node")))
+
+			Expect(".").NotTo(HaveUnstagedChanges())
+		})
+
+		It("ignores unknown flags", func() {
+			os.Chdir("../test_data/riff-init/no-matching-invoker")
+
+			invokers, err := stubInvokers("invokers/*.yaml")
+			Expect(err).NotTo(HaveOccurred())
+			rootCommand, _, _, _, err := setupInitTest(invokers)
+			Expect(err).NotTo(HaveOccurred())
+
+			rootCommand.SetArgs(append([]string{"init", "java", "--handler", "functions.FooFunc"}, commonRiffArgs...))
+
+			err = rootCommand.Execute()
+			Expect(err).To(HaveOccurred())
+			Expect(err).To(Equal(fmt.Errorf("The invoker must be specified. Pick one of: node")))
 
 			Expect(".").NotTo(HaveUnstagedChanges())
 		})