Skip to content

Commit 7e956a7

Browse files
committed
Renamed Resource::PageConfigs#add_page_config to #set_page_config
1 parent a7653fb commit 7e956a7

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

lib/active_admin/page_dsl.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class PageDSL < DSL
1515
# end
1616
#
1717
def content(options = {}, &block)
18-
config.add_page_config :index, ActiveAdmin::PageConfig.new(options, &block)
18+
config.set_page_config :index, ActiveAdmin::PageConfig.new(options, &block)
1919
end
2020
end
2121
end

lib/active_admin/resource/page_configs.rb

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,16 @@ def page_configs
99

1010
# Sets a page config for a given action
1111
#
12-
def add_page_config(action, page_config)
12+
# @param [String, Symbol] action The action to store this configuration for
13+
# @param [PageConfig] page_config The instance of PageConfig to store
14+
def set_page_config(action, page_config)
1315
page_configs[action.to_sym] = page_config
1416
end
1517

18+
# Returns a stored page config
19+
#
20+
# @param [Symbol, String] action The action to get the config for
21+
# @returns [PageConfig, nil]
1622
def get_page_config(action)
1723
page_configs[action.to_sym]
1824
end

lib/active_admin/resource_dsl.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,12 @@ def action_item(options = {}, &block)
5858
# Configure the index page for the resource
5959
def index(options = {}, &block)
6060
options[:as] ||= :table
61-
config.add_page_config :index, ActiveAdmin::PageConfig.new(options, &block)
61+
config.set_page_config :index, ActiveAdmin::PageConfig.new(options, &block)
6262
end
6363

6464
# Configure the show page for the resource
6565
def show(options = {}, &block)
66-
config.add_page_config :show, ActiveAdmin::PageConfig.new(options, &block)
66+
config.set_page_config :show, ActiveAdmin::PageConfig.new(options, &block)
6767
end
6868

6969
def form(options = {}, &block)

spec/unit/resource/page_configs_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111

1212
it "should add a page config" do
1313
page_config = ActiveAdmin::PageConfig.new
14-
resource.add_page_config(:index, page_config)
14+
resource.set_page_config(:index, page_config)
1515
resource.page_configs[:index].should == page_config
1616
end
1717

1818
describe "#get_page_config" do
1919

2020
it "should return a page config when set" do
2121
page_config = ActiveAdmin::PageConfig.new
22-
resource.add_page_config(:index, page_config)
22+
resource.set_page_config(:index, page_config)
2323
resource.get_page_config(:index).should == page_config
2424
end
2525

0 commit comments

Comments
 (0)