Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sclorg/s2i-nodejs-container
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: sclorg/s2i-nodejs-container
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: container_pytests
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 33 files changed
  • 1 contributor

Commits on Oct 14, 2025

  1. Rename test_*.py OpenShift PyTest to `test_ocp_*.py

    Signed-off-by: Petr "Stone" Hracek <[email protected]>
    phracek committed Oct 14, 2025
    Configuration menu
    Copy the full SHA
    a514983 View commit details
    Browse the repository at this point in the history
  2. Add Container PyTest for s2i-nodejs-container

    Signed-off-by: Petr "Stone" Hracek <[email protected]>
    phracek committed Oct 14, 2025
    Configuration menu
    Copy the full SHA
    a5302ce View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2025

  1. Do not run tests for minimal container

    Signed-off-by: Petr "Stone" Hracek <[email protected]>
    phracek committed Oct 15, 2025
    Configuration menu
    Copy the full SHA
    dce5bee View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2025

  1. Add PyTest also for Minimal NodeJS container

    The bash tests were migrated to PyTest by following matrix:
    
    APP without any -e DEV_MODE or -e NODE_ENV
    - test_run_app_application ->
      test_container_apps.py(TestNodeJSAppContainer class)
    - test_s2i_usage -> test_container_basics.py(TestNodeJSAppContainer
      class)
    - test_scl_usage -> test_container_basics.py(TestNodeJSAppContainer
      class)
    - test_connection -> test_container_apps.py each Class
    - test_docker_run_usage ->
      test_container_basics.py(TestNodeJSAppContainer class)
      test_container_basics.py(TestNodeJSAppContainer class)
    - test_npm_functionality
    - test_check_build_using_dockerfile ->
      test_container_basics.py(TestNodeJSAppContainer class)
    - test_nodemon_removed
    - test_npm_cache_cleared ->
      test_container_apps.py(TestNodeJSAppContainer class)
    - test_npm_tmp_cleared -> test_container_apps.py(TestNodeJSAppContainer
      class)
    - kill_test_application -> Not needed. Cleanup is done by each test.
    - test_dev_mode_true_development -> test_container_apps.py(TestNodeJSAppContainer
      class)
    - test_dev_mode_false_production -> test_container_apps.py(TestNodeJSAppContainer
      class)
    - test_node_cmd_development_init_wrapper_true -> test_container_apps.py(TestNodeJSAppContainer
      class)
    - test_node_cmd_production_init_wrapper_true -> test_container_apps.py(TestNodeJSAppContainer
      class)
    - test_node_cmd_development_init_wrapper_false -> test_container_apps.py(TestNodeJSAppContainer
      class)
    - test_init_wrapper_true_development -> test_container_apps.py(TestNodeJSAppContainer
      class)
    - test_init_wrapper_false_development -> test_container_apps.py(TestNodeJSAppContainer
      class)
    
    APP with -e NODE_ENV
    test_run_app_application -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer
      class)
    test_connection -> tested by each test
    test_nodemon_present -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer
      class)
    test_npm_cache_exists -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer
      class)
    kill_test_application -> not needed. Cleanup does it by each test
    test_dev_mode_true_development -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer
      class)
    test_dev_mode_false_development -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer
      class)
    test_node_cmd_development_init_wrapper_true -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer
      class)
    test_node_cmd_production_init_wrapper_true -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer
      class)
    test_node_cmd_production_init_wrapper_false -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer
      class)
    
    APP with DEV_MODE
    test_run_app_application ->
    test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class)
    test_connection -> tested by each test by response
    test_nodemon_present ->
    test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class)
    test_npm_cache_exists ->
    test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class)
    kill_test_application -> Not needed. It is done by each cleanup
    test_dev_mode_true_development ->
    test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class)
    test_dev_mode_false_production ->
    test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class)
    
    HW tests:
    - test_safe_logging ->
    test_container_apps(TestNodeJSAppsHWContainer class)
    - test_run_hw_application ->
    test_container_apps(TestNodeJSAppsHWContainer class)
    - test_incremental_build ->
    test_container_apps(TestNodeJSAppsHWContainer class)
    - test_build_express_webapp ->
    test_container_apps(TestNodeJSAppsHWContainer class)
    - test_node_cmd_development_init_wrapper_true ->
    test_container_apps(TestNodeJSAppsHWContainer class)
    - test_init_wrapper_false_development ->
    test_container_apps(TestNodeJSAppsHWContainer class)
    
    FIPS tests:
    - test_nodejs_fips_mode ->
      test_container_basics.py(TestNodeJSFipsContainer class)
    - test_run_fips_app_application ->
      test_container_basics.py(TestNodeJSFipsContainer class)
    
    Signed-off-by: Petr "Stone" Hracek <[email protected]>
    phracek committed Oct 16, 2025
    Configuration menu
    Copy the full SHA
    a86dde7 View commit details
    Browse the repository at this point in the history
  2. Fix FIPS mode. Move the functionality to test-fips directory

    as test.js file
    
    Signed-off-by: Petr "Stone" Hracek <[email protected]>
    phracek committed Oct 16, 2025
    Configuration menu
    Copy the full SHA
    803e341 View commit details
    Browse the repository at this point in the history
  3. Do not run FIPS tests for minimal container.

    Signed-off-by: Petr "Stone" Hracek <[email protected]>
    phracek committed Oct 16, 2025
    Configuration menu
    Copy the full SHA
    d09e3ea View commit details
    Browse the repository at this point in the history
  4. Add FIPS tests to minimal version although

    they are not tested.
    
    Signed-off-by: Petr "Stone" Hracek <[email protected]>
    phracek committed Oct 16, 2025
    Configuration menu
    Copy the full SHA
    50ffd7b View commit details
    Browse the repository at this point in the history
Loading