Validation issue

[satrianivzla]

Hi There!
Library works great but I found a couple of troubles related to the query_string value.

If you send a number over the limit like for example (?page=99) your library show no message or have a routine to send it to the first page.
Also if you put manually a string like for example (?page=x) will show you an error because the query can't be executed.

Cheers!

[scratchoo]

Hi @satrianivzla,

Thank you for reporting these issues

For the first case, when you set a number over limit like (?page=99) I think it's the normal behavior to show nothing, as the result will be an empty array!

For the second issue (?page=x), I fixed this, now if you put any string it will fall-back to the first page

Also there was some other bug fixes, + we extended the library to support custom queries (see the readme page), so I would suggest you to download the new lib file and use that instead.

Let me know if my answer was sufficient, or you see a better solution?

Regards!

[satrianivzla]

Hi there
Well if you check another pagination class you will find a small piece of code like this one to fix the 1st issue
$variable = $ci->input->get('page', TRUE);
$total_pages = (int) ceil($config['total_rows'] / $config['per_page'] );
if ( $variable > $total_pages ) {
// for example redirect to the same controller
}
I will check the updated library!

[satrianivzla]

Another thing to fix is that $config['total_rows'] can't be 0
if ( $config['total_rows'] == 0 ) {
// for example redirect to another controller
}

[scratchoo]

@satrianivzla Thank you for your suggestions, if you download the new code now, and put a page=9999 or something big, it will redirect back to the url (without page=...) which generally fall back to the very first page. The checking is done via the method prevent_unexisting_page which you can check in the source code.

For your second comment about $config['total_rows'] can't be 0 while I tested the total_rows to be 0 I can't see any error with that! can you confirm this?