Merge pull request camptocamp#19 from simahawk/bumpversion

release.bump: update marabunta file

Author: simahawk

odoo_tools/config.py

@@ -19,6 +19,7 @@
     "pending_merge_rel_path": "pending-merges.d",
     # FIXME: will be VERSION?
     "version_file_rel_path": "odoo/VERSION",
+    "marabunta_mig_file_rel_path": "odoo/migration.yml",
 }
 
 

odoo_tools/release.py

@@ -6,7 +6,9 @@
 import click
 
 from .config import get_conf_key
+from .utils import yaml
 from .utils.os_exec import run
+from .utils.path import build_path
 
 
 def parse_bumpversion_cfg(ini_content):
@@ -38,6 +40,37 @@ def make_towncrier_cmd(version):
     return "towncrier build --yes --version={}".format(version)
 
 
+class MarabuntFileHandler:
+    def __init__(self, path_obj):
+        self.path_obj = path_obj
+
+    def load(self):
+        return yaml.yaml_load(self.path_obj.open())
+
+    def update(self, version, run_click_hook="pre"):
+        data = self.load()
+        versions = data["migration"]["versions"]
+        version_item = [x for x in versions if x["version"] == version]
+        if not version_item:
+            version_item = {"version": version}
+            versions.append(version_item)
+        if not version_item.get("operations"):
+            version_item["operations"] = {}
+        operations = version_item["operations"]
+        cmd = self._make_click_odoo_update_cmd()
+        operations.setdefault(run_click_hook, []).append(cmd)
+        yaml.update_yml_file(self.path_obj, data)
+
+    def _make_click_odoo_update_cmd(self):
+        return "click-odoo-update"
+
+
+def update_marabunta_file(version):
+    marabunta_file = build_path(get_conf_key("marabunta_mig_file_rel_path"))
+    handler = MarabuntFileHandler(marabunta_file)
+    handler.update(version)
+
+
 @click.group()
 def cli():
     pass
@@ -65,6 +98,8 @@ def bump(rel_type, new_version=None, dry_run=False, commit=False):
         cmd = make_towncrier_cmd(new_version)
         click.echo(f"Running: {cmd}")
         run(cmd)
+        click.echo("Updating marabunta migration file")
+        update_marabunta_file(new_version)
 
 
 if __name__ == '__main__':

tests/common.py

@@ -49,6 +49,7 @@ def make_fake_project_root(
     marker_file=get_root_marker(),
     req_file="requirements.txt",
     proj_version="14.0.0.1.0",
+    mock_marabunta_file=False,
 ):
     data = FAKE_MANIFEST_DATA.copy()
     data.update(manifest or {})
@@ -66,6 +67,18 @@ def make_fake_project_root(
     with ver_file.open("w") as fd:
         fd.write(proj_version)
 
+    if mock_marabunta_file:
+        fake_marabunta_file()
+
+
+def fake_marabunta_file(source_file_path=None):
+    source_file_path = source_file_path or get_fixture_path("fake-marabunta.yml")
+    if not os.path.exists("odoo"):
+        os.mkdir("odoo")
+    with source_file_path.open() as fd_source:
+        with get_conf_key("marabunta_mig_file_rel_path").open("w") as fd_dest:
+            fd_dest.write(fd_source.read())
+
 
 @contextmanager
 def fake_project_root(make_root=True, **kw):

tests/fixtures/fake-marabunta.yml

@@ -0,0 +1,8 @@
+migration:
+  versions:
+    - version: setup
+      addons:
+        upgrade:
+          - foo
+          - baz
+    - version: 14.0.0.1.0 

tests/test_release.py

@@ -27,7 +27,9 @@ def test_make_towncrier_cmd():
 
 def test_bump():
     ver_file = get_conf_key("version_file_rel_path")
-    with fake_project_root(proj_version="14.0.0.1.0") as runner:
+    with fake_project_root(
+        proj_version="14.0.0.1.0", mock_marabunta_file=True
+    ) as runner:
         with ver_file.open() as fd:
             assert fd.read() == "14.0.0.1.0"
         # run init to get all files ready (eg: bumpversion)
@@ -67,7 +69,9 @@ def test_bump():
 
 
 def test_bump_changelog():
-    with fake_project_root(proj_version="14.0.0.1.0") as runner:
+    with fake_project_root(
+        proj_version="14.0.0.1.0", mock_marabunta_file=True
+    ) as runner:
         # run init to get all files ready (eg: bumpversion)
         runner.invoke(init, catch_exceptions=False)
         changes = (
@@ -96,5 +100,28 @@ def test_bump_changelog():
         assert result.output.splitlines() == [
             "Running: bumpversion minor",
             "Running: towncrier build --yes --version=14.0.0.2.0",
+            "Updating marabunta migration file",
+        ]
+        assert result.exit_code == 0
+
+
+def test_bump_update_marabunta_file():
+    with fake_project_root(
+        proj_version="14.0.0.1.0", mock_marabunta_file=True
+    ) as runner:
+        # run init to get all files ready (eg: bumpversion)
+        runner.invoke(init, catch_exceptions=False)
+        result = runner.invoke(
+            release.bump, ["--type", "minor"], catch_exceptions=False
+        )
+        with get_conf_key("marabunta_mig_file_rel_path").open() as fd:
+            content = fd.read()
+            # TODO: improve these checks
+            assert "14.0.0.2.0" in content
+            assert "click-odoo-update" in content
+        assert result.output.splitlines() == [
+            "Running: bumpversion minor",
+            "Running: towncrier build --yes --version=14.0.0.2.0",
+            "Updating marabunta migration file",
         ]
         assert result.exit_code == 0